linux-kernel - Re: [PATCH v2 4/4] nvme: Allow reauth from sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112065653.GE4873@lst.de>
Date: Wed, 12 Nov 2025 07:56:53 +0100
From: Christoph Hellwig <hch@....de>
To: alistair23@...il.com
Cc: kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
	hare@...e.de, kch@...dia.com, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v2 4/4] nvme: Allow reauth from sysfs

On Wed, Nov 12, 2025 at 09:45:18AM +1000, alistair23@...il.com wrote:
> From: Alistair Francis <alistair.francis@....com>
> 
> Allow userspace to trigger a reauth (REPLACETLSPSK) from sysfs.
> This can be done by writing to the sysfs file.
> 
> echo 0 > /sys/devices/virtual/nvme-fabrics/ctl/nvme0/tls_configured_key

This now takes absolutely any write, right?  I think we should at least
be strict to force some value, and document it.

Which reminds me that Documentation/ABI/testing/sysfs-* is missing a
lot of nvme attributes it seems :(