linux-kernel - Re: [PATCH v2 1/4] nvmet-tcp: Don't error if TLS is enabed on a reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92761459-4d5f-4cca-b0b6-fc359f07ba69@suse.de>
Date: Wed, 12 Nov 2025 08:05:55 +0100
From: Hannes Reinecke <hare@...e.de>
To: alistair23@...il.com, kbusch@...nel.org, axboe@...nel.dk, hch@....de,
 sagi@...mberg.me, kch@...dia.com, linux-nvme@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v2 1/4] nvmet-tcp: Don't error if TLS is enabed on a reset

On 11/12/25 00:45, alistair23@...il.com wrote:
> From: Alistair Francis <alistair.francis@....com>
> 
> If the host sends a AUTH_Negotiate Message on the admin queue with
> REPLACETLSPSK set then we expect and require a TLS connection and
> shouldn't report an error if TLS is enabled.
> 
> This change only enforces the nvmet_queue_tls_keyid() check if we aren't
> resetting the negotiation.
> 
> Signed-off-by: Alistair Francis <alistair.francis@....com>
> ---
> v2:
>   - Fixup long line
> 
>   drivers/nvme/target/auth.c             | 4 ++--
>   drivers/nvme/target/core.c             | 2 +-
>   drivers/nvme/target/fabrics-cmd-auth.c | 3 ++-
>   drivers/nvme/target/nvmet.h            | 4 ++--
>   4 files changed, 7 insertions(+), 6 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich