linux-kernel - Re: wifi: mac80211: make n_channels updated absolutely before accessing channels[]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <494afbf2ca5b18f230b02b03f122c4d427dd08ee.camel@sipsolutions.net>
Date: Wed, 12 Nov 2025 09:41:04 +0100
From: Johannes Berg <johannes@...solutions.net>
To: xu.xin16@....com.cn
Cc: kees@...nel.org, concord@...too.org, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org, qiu.yutan@....com.cn
Subject: Re: wifi: mac80211: make n_channels updated absolutely before
 accessing channels[]

On Wed, 2025-11-12 at 16:37 +0800, xu.xin16@....com.cn wrote:
> From: xu xin <xu.xin16@....com.cn>
> 
> The commit 2663d0462eb3 ("wifi: mac80211: Avoid address calculations via out of
> bounds array indexing") said that req->n_channels must be set before
> req->channels[] can be used. But there&apos;s still the case that req.channels
> accessing was prior to n_channels++.
> 
> This does not fix any visible bug, just making n_channels updated before
> accessing channels[] absolutely, to avoid potential UBSAN out of indexing
> warning.

I reverted the annotations, so this isn't necessary.

johannes