linux-kernel - Re: wifi: mac80211: make n_channels updated absolutely before accessing channels[]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112165040828QPfTMyxpU6TF3SvlWuQdq@zte.com.cn>
Date: Wed, 12 Nov 2025 16:50:40 +0800 (CST)
From: <xu.xin16@....com.cn>
To: <johannes@...solutions.net>
Cc: <kees@...nel.org>, <concord@...too.org>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <qiu.yutan@....com.cn>
Subject: Re: wifi: mac80211: make n_channels updated absolutely before accessing channels[]

> > From: xu xin <xu.xin16@....com.cn>
> > 
> > The commit 2663d0462eb3 ("wifi: mac80211: Avoid address calculations via out of
> > bounds array indexing") said that req->n_channels must be set before
> > req->channels[] can be used. But there&apos;s still the case that req.channels
> > accessing was prior to n_channels++.
> > 
> > This does not fix any visible bug, just making n_channels updated before
> > accessing channels[] absolutely, to avoid potential UBSAN out of indexing
> > warning.
> 
> I reverted the annotations, so this isn't necessary.

Excuse me, what is the annotations you reverted ? Maybe I missed somthing.