linux-kernel - Re: linux-next: build warnings after merge of the vfs-brauner tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGudoHEa=4HueuL8Ypfd5VNVyo5fEsfeY2+6c3nA2mvhXNt5Kw@mail.gmail.com>
Date: Wed, 12 Nov 2025 11:10:59 +0100
From: Mateusz Guzik <mjguzik@...il.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Christian Brauner <brauner@...nel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the vfs-brauner tree

On Wed, Nov 12, 2025 at 3:42 AM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> WARNING: fs/namei.c:627 function parameter 'idmap' not described in 'lookup_inode_permission_may_exec'
> WARNING: fs/namei.c:627 function parameter 'inode' not described in 'lookup_inode_permission_may_exec'
> WARNING: fs/namei.c:627 function parameter 'mask' not described in 'lookup_inode_permission_may_exec'
>

That func is a little special and I would argue it should not have
these documented. Is there a way to exempt it?

If not, we can repurpose inode_permission:
diff --git a/fs/namei.c b/fs/namei.c
index caeed986108d..edb1c98888a1 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -607,6 +607,9 @@ EXPORT_SYMBOL(inode_permission);

 /**
  * lookup_inode_permission_may_exec - Check traversal right for given inode
+ * @idmap:     idmap of the mount the inode was found from
+ * @inode:     Inode to check permission on
+ * @mask:      MAY_NOT_BLOCK or 0
  *
  * This is a special case routine for may_lookup() making assumptions specific
  * to path traversal. Use inode_permission() if you are doing something else.

> Introduced by commit
>
>   5ecf656231cc ("fs: speed up path lookup with cheaper handling of MAY_EXEC")
>
> --
> Cheers,
> Stephen Rothwell