[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <065678f2-3fbe-448e-83ae-e8b3e7ba96b3@kernel.org>
Date: Wed, 12 Nov 2025 11:23:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Griffin <peter.griffin@...aro.org>
Cc: André Draszik <andre.draszik@...aro.org>,
Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
dan.carpenter@...aro.org, kernel-team@...roid.com, willmcvicker@...gle.com,
arnd@...db.de
Subject: Re: [PATCH 1/2] dt-bindings: soc: samsung: exynos-pmu: remove syscon
for google,gs101-pmu
On 12/11/2025 11:22, Krzysztof Kozlowski wrote:
>> oneOf:
>> + - items:
>
> I expect new version (see other comment), so also please change items
> into enum and drop const from below. items is redundant for one entry in
> compatible (by convention) and having it as enum already makes it ready
> for growing the enumeration for future devices.
>
>> + - const: google,gs101-pmu
>
Ah, and there is also checkpatch warning about length of commit msg.
Best regards,
Krzysztof
Powered by blists - more mailing lists