linux-kernel - Re: [PATCH 1/2] dt-bindings: soc: samsung: exynos-pmu: remove syscon for google,gs101-pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADrjBPp_1APTM6uS9GqBRVfqHiwsiaQ7FD+5+uZakUFc2PDyzg@mail.gmail.com>
Date: Fri, 14 Nov 2025 12:01:36 +0000
From: Peter Griffin <peter.griffin@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: André Draszik <andre.draszik@...aro.org>, 
	Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, dan.carpenter@...aro.org, 
	kernel-team@...roid.com, willmcvicker@...gle.com, arnd@...db.de
Subject: Re: [PATCH 1/2] dt-bindings: soc: samsung: exynos-pmu: remove syscon
 for google,gs101-pmu

Hi Krzysztof,

Thanks for the review feedback!

On Wed, 12 Nov 2025 at 10:23, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 12/11/2025 11:22, Krzysztof Kozlowski wrote:
> >>      oneOf:
> >> +      - items:
> >
> > I expect new version (see other comment), so also please change items
> > into enum and drop const from below. items is redundant for one entry in
> > compatible (by convention) and having it as enum already makes it ready
> > for growing the enumeration for future devices.
> >
> >> +          - const: google,gs101-pmu
> >
>
>
> Ah, and there is also checkpatch warning about length of commit msg.

I just sent a new version addressing this and the other comments.

Thanks,

Peter