linux-kernel - Re: [PATCH 1/2] ASoC: Intel: atom: Replace deprecated strcpy in sst_slot_enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49fc19ea-4401-4f33-ad4d-5419acf6139a@intel.com>
Date: Wed, 12 Nov 2025 12:44:00 +0100
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
CC: <linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Liam
 Girdwood" <liam.r.girdwood@...ux.intel.com>, Peter Ujfalusi
	<peter.ujfalusi@...ux.intel.com>, Bard Liao
	<yung-chuan.liao@...ux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@...ux.intel.com>, Kai Vehmanen
	<kai.vehmanen@...ux.intel.com>, Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>, Mark Brown <broonie@...nel.org>, "Jaroslav
 Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Kuninori Morimoto
	<kuninori.morimoto.gx@...esas.com>
Subject: Re: [PATCH 1/2] ASoC: Intel: atom: Replace deprecated strcpy in
 sst_slot_enum_info



On 2025-11-11 11:47 PM, Thorsten Blum wrote:
> strcpy() is deprecated; use the safer strscpy() instead.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   sound/soc/intel/atom/sst-atom-controls.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c
> index 38116c758717..799d4f0881e3 100644
> --- a/sound/soc/intel/atom/sst-atom-controls.c
> +++ b/sound/soc/intel/atom/sst-atom-controls.c
> @@ -142,7 +142,7 @@ static int sst_slot_enum_info(struct snd_kcontrol *kcontrol,
>   
>   	if (uinfo->value.enumerated.item > e->max - 1)
>   		uinfo->value.enumerated.item = e->max - 1;
> -	strcpy(uinfo->value.enumerated.name,
> +	strscpy(uinfo->value.enumerated.name,
>   		e->texts[uinfo->value.enumerated.item]);
>   
>   	return 0;

If you go for one-patch approach as suggested by me in the PATCH 2/2 
review, the title should be: 'ASoC: Intel: atom: Replace strcpy() with 
strscpy()'

For this patch, both for v1 and v2 (if any):

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>