linux-kernel - Re: [PATCH 2/2] ASoC: Intel: sst: Replace deprecated strcpy in sst_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <930835ae-b65b-408f-84ff-d2ddaf4b58e8@intel.com>
Date: Wed, 12 Nov 2025 12:41:00 +0100
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
CC: <linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Liam
 Girdwood" <liam.r.girdwood@...ux.intel.com>, Peter Ujfalusi
	<peter.ujfalusi@...ux.intel.com>, Bard Liao
	<yung-chuan.liao@...ux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@...ux.intel.com>, Kai Vehmanen
	<kai.vehmanen@...ux.intel.com>, Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>, Mark Brown <broonie@...nel.org>, "Jaroslav
 Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 2/2] ASoC: Intel: sst: Replace deprecated strcpy in
 sst_acpi_probe

On 2025-11-11 11:47 PM, Thorsten Blum wrote:
> strcpy() is deprecated; use the safer strscpy() instead.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   sound/soc/intel/atom/sst/sst_acpi.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
> index 257180630475..73624e1b138a 100644
> --- a/sound/soc/intel/atom/sst/sst_acpi.c
> +++ b/sound/soc/intel/atom/sst/sst_acpi.c
> @@ -12,6 +12,7 @@
>   #include <linux/fs.h>
>   #include <linux/interrupt.h>
>   #include <linux/slab.h>
> +#include <linux/string.h>
>   #include <linux/io.h>
>   #include <linux/platform_device.h>
>   #include <linux/firmware.h>
> @@ -356,7 +357,7 @@ static int sst_acpi_probe(struct platform_device *pdev)
>   
>   	/* Fill sst platform data */
>   	ctx->pdata = pdata;
> -	strcpy(ctx->firmware_name, mach->fw_filename);
> +	strscpy(ctx->firmware_name, mach->fw_filename);
>   
>   	ret = sst_platform_get_resources(ctx);
>   	if (ret)

Thank you for the fix. I'd update the title though as 'sst' is 
confusing. It stands for Smart Sound Technology and applies to most 
things sound/soc/intel/*.

Go with either 'ASoC: Intel: atom: sst: ' or just 'ASoC: Intel: atom: '. 
In fact, I'd just merge the two patches together given that both address 
one driver - Intel atom sound driver.

Given that this is a small change, feel free to append in v2:

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>