linux-kernel - Re: [PATCH net-next v1 5/7] ptp: ocp: Reuse META's PCI vendor ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09c1ed91-7a04-49b2-a721-2ea9a4b2e44a@linux.dev>
Date: Wed, 12 Nov 2025 13:37:04 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Richard Cochran <richardcochran@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1 5/7] ptp: ocp: Reuse META's PCI vendor ID

On 11/11/2025 16:52, Andy Shevchenko wrote:
> The META's PCI vendor ID is listed already in the pci_ids.h.
> Reuse it here.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/ptp/ptp_ocp.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 67a4c60cbbcd..4c4b4a40e9d4 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -25,8 +25,7 @@
>   #include <linux/crc16.h>
>   #include <linux/dpll.h>
>   
> -#define PCI_VENDOR_ID_FACEBOOK			0x1d9b
> -#define PCI_DEVICE_ID_FACEBOOK_TIMECARD		0x0400
> +#define PCI_DEVICE_ID_META_TIMECARD		0x0400
>   
>   #define PCI_VENDOR_ID_CELESTICA			0x18d4
>   #define PCI_DEVICE_ID_CELESTICA_TIMECARD	0x1008
> @@ -1030,7 +1029,7 @@ static struct ocp_resource ocp_adva_resource[] = {
>   };
>   
>   static const struct pci_device_id ptp_ocp_pcidev_id[] = {
> -	{ PCI_DEVICE_DATA(FACEBOOK, TIMECARD, &ocp_fb_resource) },
> +	{ PCI_DEVICE_DATA(META, TIMECARD, &ocp_fb_resource) },
>   	{ PCI_DEVICE_DATA(CELESTICA, TIMECARD, &ocp_fb_resource) },
>   	{ PCI_DEVICE_DATA(OROLIA, ARTCARD, &ocp_art_resource) },
>   	{ PCI_DEVICE_DATA(ADVA, TIMECARD, &ocp_adva_resource) },

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>