linux-kernel - Re: [PATCH net-next v1 2/7] ptp: ocp: Make ptp_ocp_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d10e9ac-98b1-4a75-a61a-85a59c8efd86@linux.dev>
Date: Wed, 12 Nov 2025 13:38:44 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Richard Cochran <richardcochran@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1 2/7] ptp: ocp: Make ptp_ocp_unregister_ext()
 NULL-aware

On 11/11/2025 16:52, Andy Shevchenko wrote:
> It's a common practice to make resource release functions be NULL-aware.
> Make ptp_ocp_unregister_ext() NULL-aware.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/ptp/ptp_ocp.c | 24 ++++++++++--------------
>   1 file changed, 10 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 95889f85ffb2..28243fb1d78f 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -2225,6 +2225,9 @@ ptp_ocp_ts_enable(void *priv, u32 req, bool enable)
>   static void
>   ptp_ocp_unregister_ext(struct ptp_ocp_ext_src *ext)
>   {
> +	if (!ext)
> +		return;
> +
>   	ext->info->enable(ext, ~0, false);
>   	pci_free_irq(ext->bp->pdev, ext->irq_vec, ext);
>   	kfree(ext);
> @@ -4558,21 +4561,14 @@ ptp_ocp_detach(struct ptp_ocp *bp)
>   	ptp_ocp_detach_sysfs(bp);
>   	ptp_ocp_attr_group_del(bp);
>   	timer_delete_sync(&bp->watchdog);
> -	if (bp->ts0)
> -		ptp_ocp_unregister_ext(bp->ts0);
> -	if (bp->ts1)
> -		ptp_ocp_unregister_ext(bp->ts1);
> -	if (bp->ts2)
> -		ptp_ocp_unregister_ext(bp->ts2);
> -	if (bp->ts3)
> -		ptp_ocp_unregister_ext(bp->ts3);
> -	if (bp->ts4)
> -		ptp_ocp_unregister_ext(bp->ts4);
> -	if (bp->pps)
> -		ptp_ocp_unregister_ext(bp->pps);
> +	ptp_ocp_unregister_ext(bp->ts0);
> +	ptp_ocp_unregister_ext(bp->ts1);
> +	ptp_ocp_unregister_ext(bp->ts2);
> +	ptp_ocp_unregister_ext(bp->ts3);
> +	ptp_ocp_unregister_ext(bp->ts4);
> +	ptp_ocp_unregister_ext(bp->pps);
>   	for (i = 0; i < 4; i++)
> -		if (bp->signal_out[i])
> -			ptp_ocp_unregister_ext(bp->signal_out[i]);
> +		ptp_ocp_unregister_ext(bp->signal_out[i]);
>   	for (i = 0; i < __PORT_COUNT; i++)
>   		if (bp->port[i].line != -1)
>   			serial8250_unregister_port(bp->port[i].line);
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>