linux-kernel - Re: [PATCH v2 4/4] nvme: Allow reauth from sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKmqyKN8nv+D1BzDTAm4AayM0NgWWUY8Z7-o2Ru6CSq7nU9ECA@mail.gmail.com>
Date: Thu, 13 Nov 2025 22:23:30 +1000
From: Alistair Francis <alistair23@...il.com>
To: Christoph Hellwig <hch@....de>
Cc: kbusch@...nel.org, axboe@...nel.dk, sagi@...mberg.me, hare@...e.de, 
	kch@...dia.com, linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v2 4/4] nvme: Allow reauth from sysfs

On Wed, Nov 12, 2025 at 4:56 PM Christoph Hellwig <hch@....de> wrote:
>
> On Wed, Nov 12, 2025 at 09:45:18AM +1000, alistair23@...il.com wrote:
> > From: Alistair Francis <alistair.francis@....com>
> >
> > Allow userspace to trigger a reauth (REPLACETLSPSK) from sysfs.
> > This can be done by writing to the sysfs file.
> >
> > echo 0 > /sys/devices/virtual/nvme-fabrics/ctl/nvme0/tls_configured_key
>
> This now takes absolutely any write, right?  I think we should at least
> be strict to force some value, and document it.

Yes, it now takes any value. I can change it to a bool-ish (so write 1
to trigger)

>
> Which reminds me that Documentation/ABI/testing/sysfs-* is missing a
> lot of nvme attributes it seems :(

Yeah, that's why I didn't add this one. I'll have a look at updating this

Alistair

>