linux-kernel - Re: [PATCH v5] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e2b54aa-8838-4613-9b50-29d07bd6e8c1@oss.qualcomm.com>
Date: Thu, 13 Nov 2025 13:53:17 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Wei Zhang <wei.zhang@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_miaoqing@...cinc.com,
        quic_zhichen@...cinc.com
Subject: Re: [PATCH v5] arm64: dts: qcom: qcs8300-ride: enable WLAN on
 qcs8300-ride

On 11/13/25 6:51 AM, Wei Zhang wrote:
> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> of the WCN6855 and assigning its LDO power outputs to the existing
> WiFi module.
> 
> On the qcs8300-ride platform, the corresponding firmware and BDF
> are QCA6698AQ instead of WCN6855, which have been added in the
> 20250211 release.
> 
> Signed-off-by: Wei Zhang <wei.zhang@....qualcomm.com>
> ---

[...]

> +		wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;

You say active-high here

[...]

> +	wlan_en_state: wlan-en-state {
> +		pins = "gpio54";
> +		function = "gpio";
> +		bias-pull-up;
> +		output-low;

and active-low here..

Please remove the latter line

Konrad