linux-kernel - Re: [PATCH 1/8] s390/ptrace: Rename psw_t32 to psw32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <534cd250-1ebb-4c72-8c6a-49cef88568cf@linux.ibm.com>
Date: Thu, 13 Nov 2025 09:28:22 -0600
From: Jimmy Brisson <jbrisson@...ux.ibm.com>
To: Heiko Carstens <hca@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Vasily Gorbik
 <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Andreas Krebbel
 <krebbel@...ux.ibm.com>,
        Arnd Bergmann <arnd@...db.de>,
        Thomas Weißschuh <linux@...ssschuh.net>,
        Willy Tarreau <w@....eu>, Andrii Nakryiko <andrii@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH 1/8] s390/ptrace: Rename psw_t32 to psw32_t

On 11/13/25 9:07 AM, Heiko Carstens wrote:
> Use a standard "_t" suffix for psw_t32 and rename it to psw32_t.
> 
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> ---
>   arch/s390/boot/ipl_data.c       | 2 +-
>   arch/s390/include/asm/ptrace.h  | 2 +-
>   arch/s390/kernel/compat_linux.h | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/s390/boot/ipl_data.c b/arch/s390/boot/ipl_data.c
> index c4130a80b058..7957cc6554e7 100644
> --- a/arch/s390/boot/ipl_data.c
> +++ b/arch/s390/boot/ipl_data.c
> @@ -12,7 +12,7 @@
>   #define PSW_MASK_DISABLED (PSW_MASK_WAIT | PSW_MASK_EA | PSW_MASK_BA)
>   
>   struct ipl_lowcore {
> -	psw_t32		ipl_psw;			/* 0x0000 */
> +	psw32_t		ipl_psw;			/* 0x0000 */
>   	struct ccw0	ccwpgm[2];			/* 0x0008 */
>   	u8		fill[56];			/* 0x0018 */
>   	struct ccw0	ccwpgmcc[20];			/* 0x0050 */
> diff --git a/arch/s390/include/asm/ptrace.h b/arch/s390/include/asm/ptrace.h
> index dfa770b15fad..f2ecc013a48a 100644
> --- a/arch/s390/include/asm/ptrace.h
> +++ b/arch/s390/include/asm/ptrace.h
> @@ -99,7 +99,7 @@ enum {
>   typedef struct {
>   	unsigned int mask;
>   	unsigned int addr;
> -} psw_t32 __aligned(8);
> +} psw32_t __aligned(8);
>   
>   #define PGM_INT_CODE_MASK	0x7f
>   #define PGM_INT_CODE_PER	0x80
> diff --git a/arch/s390/kernel/compat_linux.h b/arch/s390/kernel/compat_linux.h
> index ef23739b277c..133f22b5deeb 100644
> --- a/arch/s390/kernel/compat_linux.h
> +++ b/arch/s390/kernel/compat_linux.h
> @@ -33,7 +33,7 @@ typedef struct {
>   } _s390_fp_regs32;
>   
>   typedef struct {
> -	psw_t32		psw;
> +	psw32_t		psw;
>   	__u32		gprs[__NUM_GPRS];
>   	__u32		acrs[__NUM_ACRS];
>   } _s390_regs_common32;

Looks great

Reviewed-by: Jimmy Brisson <jbrisson@...ux.ibm.com>

-Jimmy