linux-kernel - Re: [PATCH 4/8] tools: Remove s390 compat support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72a8ffff-5074-4a7f-94ee-454c21f8a130@t-8ch.de>
Date: Thu, 13 Nov 2025 16:43:59 +0100
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Alexander Gordeev <agordeev@...ux.ibm.com>, 
	Vasily Gorbik <gor@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, 
	Sven Schnelle <svens@...ux.ibm.com>, Andreas Krebbel <krebbel@...ux.ibm.com>, 
	Arnd Bergmann <arnd@...db.de>, Willy Tarreau <w@....eu>, Andrii Nakryiko <andrii@...nel.org>, 
	Alexei Starovoitov <ast@...nel.org>, linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH 4/8] tools: Remove s390 compat support

On 2025-11-13 16:07:26+0100, Heiko Carstens wrote:
> Remove s390 compat support from everything within tools, since s390 compat
> support will be removed from the kernel.
> 
> While removing s390 compat code replace __s390__ ifdef guards with
> __s390x__ everywhere. Even though this is not strictly required this
> makes it easier to spot s390 compat code support leftovers.
> 
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> ---
>  .../arch/s390/include/uapi/asm/bitsperlong.h  |  4 --

Wouldn't it make sense to emit an explicit error from the UAPI
headers if a user tries to use them in 31-bit mode?

>  tools/lib/bpf/libbpf.c                        |  4 --
>  tools/lib/bpf/usdt.c                          |  2 -

>  tools/include/nolibc/arch-s390.h              |  5 ---
>  tools/include/nolibc/arch.h                   |  2 +-
>  .../testing/selftests/nolibc/Makefile.nolibc  |  5 ---
>  tools/testing/selftests/nolibc/run-tests.sh   |  6 +--

Acked-by: Thomas Weißschuh <linux@...ssschuh.net> # tools/nolibc selftests/nolibc

>  tools/testing/selftests/rseq/rseq-s390.h      | 39 -------------------

>  tools/testing/selftests/vDSO/vdso_config.h    |  4 --

Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net> # selftests/vDSO

>  9 files changed, 2 insertions(+), 69 deletions(-)

(...)


Thomas