linux-kernel - Re: [PATCH net-next 2/5] net: fec: simplify the conditional preprocessor directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRYG2YqpeOr3U3XS@lizhi-Precision-Tower-5810>
Date: Thu, 13 Nov 2025 11:27:05 -0500
From: Frank Li <Frank.li@....com>
To: Wei Fang <wei.fang@....com>
Cc: Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"eric@...int.com" <eric@...int.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/5] net: fec: simplify the conditional
 preprocessor directives

On Wed, Nov 12, 2025 at 01:53:15AM +0000, Wei Fang wrote:
> > > -	if (!of_machine_is_compatible("fsl,imx6ul")) {
> > > -		reg_list = fec_enet_register_offset;
> > > -		reg_cnt = ARRAY_SIZE(fec_enet_register_offset);
> > > -	} else {
> > > +
> > > +#if !defined(CONFIG_M5272) || defined(CONFIG_COMPILE_TEST)
> > > +	if (of_machine_is_compatible("fsl,imx6ul")) {
> >
> > There are stub of_machine_is_compatible(), so needn't #ifdef here.
> >
>
> fec_enet_register_offset_6ul is not defined when CONFIG_M5272 is
> enabled, so we still need it here.

Is it possible to remove ifdef for fec_enet_register_offset_6ul?

Frank
>
> > >  		reg_list = fec_enet_register_offset_6ul;
> > >  		reg_cnt = ARRAY_SIZE(fec_enet_register_offset_6ul);
> > >  	}
> > > -#else
> > > -	/* coldfire */
> > > -	static u32 *reg_list = fec_enet_register_offset;
> > > -	static const u32 reg_cnt = ARRAY_SIZE(fec_enet_register_offset);
> > >  #endif
> > >  	ret = pm_runtime_resume_and_get(dev);
> > >  	if (ret < 0)
> > > --
> > > 2.34.1
> > >