linux-kernel - Re: linux-next: Fixes tag needs some work in the block tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c2267cc-6b5a-40ce-b428-05d6ace6f2c9@kernel.dk>
Date: Thu, 13 Nov 2025 16:45:18 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Damien Le Moal <dlemoal@...nel.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On 11/13/25 4:38 PM, Damien Le Moal wrote:
> On 11/14/25 8:07 AM, Jens Axboe wrote:
>> On 11/13/25 3:04 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   7b2038b1b1d4 ("dm: fix zone reset all operation processing")
>>>
>>> Fixes tag
>>>
>>>   Fixes: db9aed869f34 ("block: introduce disk_report_zone()").
>>>
>>> has these problem(s):
>>>
>>>   - Target SHA1 does not exist
>>>
>>> Maybe you meant
>>>
>>> Fixes: fdb9aed869f3 ("block: introduce disk_report_zone()")
>>
>> Guys, that's now three funky shas that have never existed in my tree.
>> Can we please exercise a bit more diligence in actually tagging patches
>> correctly?
> 
> My apologies about this. I was careful to take these from a fresh pull of
> block/for-next but I obviously screwed-up the copy paste, missing the first
> character.

Just add something like this to your git config:

[core]
	abbrev = 12
[pretty] 
	fixes = Fixes: %h (\"%s\")
[alias]
	fixes = log -1 --format=fixes

and then you just do:

axboe@...ax ~/gi/linux (for-next)> git fixes fdb9aed869f34d776298b3a8197909eb820e4d0d
Fixes: fdb9aed869f3 ("block: introduce disk_report_zone()")

and then you're just copying that entire line, making an error much less
likely. Still won't catch someone using the wrong SHA, but it would've
prevented your issue at least.

-- 
Jens Axboe