linux-kernel - RE: [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <ZQ2PR01MB13076544E2136E7E7C2EEDA1E6CD2@ZQ2PR01MB1307.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 13 Nov 2025 03:42:05 +0000
From: Hal Feng <hal.feng@...rfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@...onical.com>, Albert Ou
	<aou@...s.berkeley.edu>, Bjorn Helgaas <bhelgaas@...gle.com>, Conor Dooley
	<conor+dt@...nel.org>, E Shattow <e@...eshell.de>, Heinrich Schuchardt
	<heinrich.schuchardt@...onical.com>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Krzysztof Wilczyński
	<kwilczynski@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
	Paul Walmsley <pjw@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>, Rob
 Herring <robh@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board

> On 12.11.25 21:54, Emil Renner Berthing wrote:
> Quoting Hal Feng (2025-11-07 10:55:22)
> > VisionFive 2 Lite is a mini SBC based on the StarFive JH7110S
> > industrial SoC which can run at -40~85 degrees centigrade and up to
> 1.25GHz.
> >
> > Board features:
> > - JH7110S SoC
> > - 4/8 GiB LPDDR4 DRAM
> > - AXP15060 PMIC
> > - 40 pin GPIO header
> > - 1x USB 3.0 host port
> > - 3x USB 2.0 host port
> > - 1x M.2 M-Key (size: 2242)
> > - 1x MicroSD slot (optional non-removable 64GiB eMMC)
> > - 1x QSPI Flash
> > - 1x I2C EEPROM
> > - 1x 1Gbps Ethernet port
> > - SDIO-based Wi-Fi & UART-based Bluetooth
> > - 1x HDMI port
> > - 1x 2-lane DSI
> > - 1x 2-lane CSI
> >
> > VisionFive 2 Lite schematics:
> > https://doc-
> en.rvspace.org/VisionFive2Lite/PDF/VF2_LITE_V1.10_TF_20250
> > 818_SCH.pdf VisionFive 2 Lite Quick Start Guide:
> > https://doc-en.rvspace.org/VisionFive2Lite/VisionFive2LiteQSG/index.ht
> > ml More documents:
> > https://doc-en.rvspace.org/Doc_Center/visionfive_2_lite.html
> 
> 
> Hi Hal,
> 
> Currently the JH7110 device trees are layed out like this, with a nice separation
> between the SoC description and board descriptions:
> 
> jh7110.dtsi               # JH7110 SoC description
> |- jh7110-common.dtsi     # Peripherals common to all JH7110 boards
>    |- jh7110-starfive-visionfive-2.dtsi # Peripherals common to VF2 boards
>    |  |- <VF2 boards>     # Final VF2 board descriptions
>    |- jh7110-milkv-marscm.dtsi # Peripherals common to Mars CM boards
>    |  |- <Mars CM boards> # Final Mars CM board descriptions
>    |- <other boards>      # Other JH7110 board descriptions
> 
> With this series it moves to
> 
> jh711x.dtsi
> |- jh711x-common.dtsi
>    |- jh7110-common.dtsi
>    |  |- <jh7110 boards>
>    |- jh7110s-common.dtsi
>       |- <jh7110s boards>
> 
> ..which I can't even give clear labels like above. In other words when new
> patches are sent in it would not be easy to explain exactly where each change
> should go and why.
> I'm also worried that you'll find that more of the peripherals on the JH7110S
> need special handling and a new jh7110s-... compatible string. Then I guess
> they'll need to jump from jh7110x.dtsi two levels down to jh7110{,s}-
> common.dtsi which then both describe SoC and board properties.
> 
> If you're serious about calling this a new SoC then I'd expect something more
> like this:
> 
> jh711x.dtsi                  # Peripherals common to both SoCs
> |- jh7110.dtsi               # JH7110 SoC description
> |  |- jh7110-common.dtsi     # Peripherals common to all JH7110 boards
> |     |- jh7110-starfive-visionfive-2.dtsi # Peripherals common to VF2 boards
> |     |  |- <VF2 boards>     # Final VF2 board descriptions
> |     |- jh7110-milkv-marscm.dtsi # Peripherals common to Mars CM boards
> |     |  |- <Mars CM boards> # Final Mars CM board descriptions
> |     |- <other boards>      # Other JH7110 board descriptions
> |- jh7110s.dtsi              # JH7110S SoC description
>    |- jh7110s-common.dtsi    # Peripherals common to all JH7110S boards
>       |- <JH7110S boards>    # Final JH7110S board descriptions
> 
> I know this will mean some duplication in jh7110{,s}-common.dtsi, but I
> would prefer that to not having a clear explanation of what each file describes.
> 
> Do you think this layout could work for you?

Yeah, it is clearer for developers and maintainers.

Considering Conor's suggestion, what about:

jh7110.dtsi               # JH7110 SoC description
|- jh7110-common.dtsi     # Peripherals common to all JH7110 boards
   |- jh7110-starfive-visionfive-2.dtsi # Peripherals common to VF2 boards
   |  |- <VF2 boards>     # Final VF2 board descriptions
   |- jh7110-milkv-marscm.dtsi # Peripherals common to Mars CM boards
   |  |- <Mars CM boards> # Final Mars CM board descriptions
   |- <other boards>      # Other JH7110 board descriptions
|- <JH7110S boards>

Move the opp table from jh7110.dtsi to jh7110-common.dtsi.
Remove jh7110s-common.dtsi, because only one board uses JH7110S now.

Best regards,
Hal