linux-kernel - Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a84afd6d-a9ec-48f2-b681-7ad6f6e428cb@kernel.org>
Date: Thu, 13 Nov 2025 10:11:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>,
 Xu Yilun <yilun.xu@...ux.intel.com>
Cc: Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
 Tom Rix <trix@...hat.com>, Dinh Nguyen <dinguyen@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, "Rao, Mahesh" <mahesh.rao@...era.com>,
 "Ng, Adrian Ho Yin" <adrian.ho.yin.ng@...era.com>,
 "Rabara, Niravkumar Laxmidas" <nirav.rabara@...era.com>,
 "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr
 nodes

On 13/11/2025 10:09, Romli, Khairul Anuar wrote:
> On 13/11/2025 3:12 pm, Krzysztof Kozlowski wrote:
>> On 13/11/2025 06:55, Xu Yilun wrote:
>>> On Thu, Nov 13, 2025 at 12:43:56PM +0800, Khairul Anuar Romli wrote:
>>>> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
>>>> proper device tree description to enable FPGA manager support in the Linux
>>>> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
>>>> detect or manage the FPGA hardware correctly.
>>>>
>>>> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
>>>> with appropriate #address-cells and #size-cells properties, to describe the
>>>> FPGA region layout.
>>>>
>>>> Also defines specific compatible string for Agilex5 and add Agilex string
>>>> as fallback for stratix10-soc driver initialization.
>>>>
>>>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
>>>
>>> Reviewed-by: Xu Yilun <yilun.xu@...el.com>
>>
>> How this can be reviewed if it is completely wrong and obviously not
>> matching the bindings from this patchset?
>>
>> Best regards,
>> Krzysztof
> 
> Could you point out which part that I need to fix?
>

Why? Tools tell you that. Why are you expecting the community to do the
job of compiler/toolchain/toolset? We have better things to do.

Best regards,
Krzysztof