linux-kernel - Re: [PATCH v6 00/15] Create and use APIs to centralise locking for directory ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b30eac3d6368d2eb03a2acbae113455b65753e0c.camel@kernel.org>
Date: Fri, 14 Nov 2025 09:05:51 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Christian Brauner <brauner@...nel.org>, NeilBrown <neil@...wn.name>
Cc: Alexander Viro <viro@...iv.linux.org.uk>, Amir Goldstein	
 <amir73il@...il.com>, Jan Kara <jack@...e.cz>,
 linux-fsdevel@...r.kernel.org,  Chris Mason	 <clm@...com>, David Sterba
 <dsterba@...e.com>, David Howells <dhowells@...hat.com>,  Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Danilo Krummrich	 <dakr@...nel.org>, Tyler Hicks
 <code@...icks.com>, Miklos Szeredi	 <miklos@...redi.hu>, Chuck Lever
 <chuck.lever@...cle.com>, Olga Kornievskaia	 <okorniev@...hat.com>, Dai Ngo
 <Dai.Ngo@...cle.com>, Namjae Jeon	 <linkinjeon@...nel.org>, Steve French
 <smfrench@...il.com>, Sergey Senozhatsky	 <senozhatsky@...omium.org>,
 Carlos Maiolino <cem@...nel.org>, John Johansen	
 <john.johansen@...onical.com>, Paul Moore <paul@...l-moore.com>, James
 Morris	 <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, Stephen
 Smalley	 <stephen.smalley.work@...il.com>, Ondrej Mosnacek
 <omosnace@...hat.com>,  Mateusz Guzik <mjguzik@...il.com>, Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>, Stefan Berger	 <stefanb@...ux.ibm.com>,
 "Darrick J. Wong" <djwong@...nel.org>, 	linux-kernel@...r.kernel.org,
 netfs@...ts.linux.dev, ecryptfs@...r.kernel.org, 
	linux-nfs@...r.kernel.org, linux-unionfs@...r.kernel.org, 
	linux-cifs@...r.kernel.org, linux-xfs@...r.kernel.org, 
	linux-security-module@...r.kernel.org, selinux@...r.kernel.org
Subject: Re: [PATCH v6 00/15] Create and use APIs to centralise locking for
 directory ops

On Fri, 2025-11-14 at 13:24 +0100, Christian Brauner wrote:
> On Thu, Nov 13, 2025 at 11:18:23AM +1100, NeilBrown wrote:
> > Following is a new version of this series:
> >  - fixed a bug found by syzbot
> >  - cleanup suggested by Stephen Smalley
> >  - added patch for missing updates in smb/server - thanks Jeff Layton
> 
> The codeflow right now is very very gnarly in a lot of places which
> obviously isn't your fault. But start_creating() and end_creating()
> would very naturally lend themselves to be CLASS() guards.
> 
> Unrelated: I'm very inclined to slap a patch on top that renames
> start_creating()/end_creating() and start_dirop()/end_dirop() to
> vfs_start_creating()/vfs_end_creating() and
> vfs_start_dirop()/vfs_end_dirop(). After all they are VFS level
> maintained helpers and I try to be consistent with the naming in the
> codebase making it very easy to grep.

That sounds like a good idea. The current names are a little too
generic.
-- 
Jeff Layton <jlayton@...nel.org>