linux-kernel - Re: [PATCH 1/2] block/blk-throttle: Fix throttle slice time for SSDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9efd5cb-d3cc-48df-8dda-2b3d85e2190b@kernel.dk>
Date: Fri, 14 Nov 2025 13:51:46 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Khazhy Kumykov <khazhy@...omium.org>, Tejun Heo <tj@...nel.org>
Cc: yukuai@...nel.org, Guenter Roeck <linux@...ck-us.net>,
 Josef Bacik <josef@...icpanda.com>, Yu Kuai <yukuai3@...wei.com>,
 cgroups@...r.kernel.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] block/blk-throttle: Fix throttle slice time for SSDs

On 11/14/25 1:26 PM, Khazhy Kumykov wrote:
> On Wed, Jul 30, 2025 at 4:19 PM Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> On 7/30/25 11:30, Yu Kuai wrote:
>> I had combined it because it is another left-over from bf20ab538c81 and
>> I don't know if enabling statistics has other side effects. But, sure,
>> I can split it out if that is preferred. Let's wait for feedback from
>> Jens and/or Tejun; I'll follow their guidance.
>>
>> Thanks,
>> Guenter
>>
> noticed this one in our carry queue... any further guidance here? If
> my opinion counts, since this is a fixup for a "remove feature X"
> commit... I would have done it in one commit as well :)

I agree with Yu that a split of patch 1 would be appropriate.

-- 
Jens Axboe