[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aea2df71-a255-4980-a75d-4918a7b2eac6@roeck-us.net>
Date: Fri, 14 Nov 2025 16:30:49 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Jens Axboe <axboe@...nel.dk>, Khazhy Kumykov <khazhy@...omium.org>,
Tejun Heo <tj@...nel.org>
Cc: yukuai@...nel.org, Josef Bacik <josef@...icpanda.com>,
Yu Kuai <yukuai3@...wei.com>, cgroups@...r.kernel.org,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] block/blk-throttle: Fix throttle slice time for SSDs
On 11/14/25 12:51, Jens Axboe wrote:
> On 11/14/25 1:26 PM, Khazhy Kumykov wrote:
>> On Wed, Jul 30, 2025 at 4:19 PM Guenter Roeck <linux@...ck-us.net> wrote:
>>>
>>> On 7/30/25 11:30, Yu Kuai wrote:
>>> I had combined it because it is another left-over from bf20ab538c81 and
>>> I don't know if enabling statistics has other side effects. But, sure,
>>> I can split it out if that is preferred. Let's wait for feedback from
>>> Jens and/or Tejun; I'll follow their guidance.
>>>
>>> Thanks,
>>> Guenter
>>>
>> noticed this one in our carry queue... any further guidance here? If
>> my opinion counts, since this is a fixup for a "remove feature X"
>> commit... I would have done it in one commit as well :)
>
> I agree with Yu that a split of patch 1 would be appropriate.
>
I completely forgot about this, sorry.
I was about to send a new version, but Khazy was faster.
Thanks!
Guenter
Powered by blists - more mailing lists