linux-kernel - Re: [PATCH net-next v5 1/2] net: mana: Handle SKB if TX SGEs exceed hardware limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJotxTiQQwEJbtRbkAa0XYkuyv4z_La7WjYHQDvon-miw@mail.gmail.com>
Date: Fri, 14 Nov 2025 13:26:55 -0800
From: Eric Dumazet <edumazet@...gle.com>
To: Aditya Garg <gargaditya@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org, 
	decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	kuba@...nel.org, pabeni@...hat.com, longli@...rosoft.com, 
	kotaranov@...rosoft.com, horms@...nel.org, shradhagupta@...ux.microsoft.com, 
	ssengar@...ux.microsoft.com, ernis@...ux.microsoft.com, 
	dipayanroy@...ux.microsoft.com, shirazsaleem@...rosoft.com, leon@...nel.org, 
	mlevitsk@...hat.com, yury.norov@...il.com, sbhatta@...vell.com, 
	linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org, 
	gargaditya@...rosoft.com
Subject: Re: [PATCH net-next v5 1/2] net: mana: Handle SKB if TX SGEs exceed
 hardware limit

On Fri, Nov 14, 2025 at 1:19 PM Aditya Garg
<gargaditya@...ux.microsoft.com> wrote:
>
> The MANA hardware supports a maximum of 30 scatter-gather entries (SGEs)
> per TX WQE. Exceeding this limit can cause TX failures.
> Add ndo_features_check() callback to validate SKB layout before
> transmission. For GSO SKBs that would exceed the hardware SGE limit, clear
> NETIF_F_GSO_MASK to enforce software segmentation in the stack.
> Add a fallback in mana_start_xmit() to linearize non-GSO SKBs that still
> exceed the SGE limit.
>
> Also, Add ethtool counter for SKBs linearized
>
> Co-developed-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
> Signed-off-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
> Signed-off-by: Aditya Garg <gargaditya@...ux.microsoft.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>