linux-kernel - RE: [PATCH net-next v5 1/2] net: mana: Handle SKB if TX SGEs exceed hardware limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA3PR21MB38678841F708F1B85DD1E216CAC8A@SA3PR21MB3867.namprd21.prod.outlook.com>
Date: Sun, 16 Nov 2025 21:36:52 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Aditya Garg <gargaditya@...ux.microsoft.com>, KY Srinivasan
	<kys@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, Dexuan Cui
	<DECUI@...rosoft.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, Long Li <longli@...rosoft.com>,
	Konstantin Taranov <kotaranov@...rosoft.com>, "horms@...nel.org"
	<horms@...nel.org>, "shradhagupta@...ux.microsoft.com"
	<shradhagupta@...ux.microsoft.com>, "ssengar@...ux.microsoft.com"
	<ssengar@...ux.microsoft.com>, "ernis@...ux.microsoft.com"
	<ernis@...ux.microsoft.com>, "dipayanroy@...ux.microsoft.com"
	<dipayanroy@...ux.microsoft.com>, Shiraz Saleem <shirazsaleem@...rosoft.com>,
	"leon@...nel.org" <leon@...nel.org>, "mlevitsk@...hat.com"
	<mlevitsk@...hat.com>, "yury.norov@...il.com" <yury.norov@...il.com>,
	"sbhatta@...vell.com" <sbhatta@...vell.com>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, Aditya Garg <gargaditya@...rosoft.com>
Subject: RE: [PATCH net-next v5 1/2] net: mana: Handle SKB if TX SGEs exceed
 hardware limit



> -----Original Message-----
> From: Aditya Garg <gargaditya@...ux.microsoft.com>
> Sent: Friday, November 14, 2025 4:17 PM
> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; wei.liu@...nel.org; Dexuan Cui
> <DECUI@...rosoft.com>; andrew+netdev@...n.ch; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; Long Li
> <longli@...rosoft.com>; Konstantin Taranov <kotaranov@...rosoft.com>;
> horms@...nel.org; shradhagupta@...ux.microsoft.com;
> ssengar@...ux.microsoft.com; ernis@...ux.microsoft.com;
> dipayanroy@...ux.microsoft.com; Shiraz Saleem
> <shirazsaleem@...rosoft.com>; leon@...nel.org; mlevitsk@...hat.com;
> yury.norov@...il.com; sbhatta@...vell.com; linux-hyperv@...r.kernel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> rdma@...r.kernel.org; Aditya Garg <gargaditya@...rosoft.com>
> Cc: Aditya Garg <gargaditya@...ux.microsoft.com>
> Subject: [PATCH net-next v5 1/2] net: mana: Handle SKB if TX SGEs exceed
> hardware limit
> 
> The MANA hardware supports a maximum of 30 scatter-gather entries (SGEs)
> per TX WQE. Exceeding this limit can cause TX failures.
> Add ndo_features_check() callback to validate SKB layout before
> transmission. For GSO SKBs that would exceed the hardware SGE limit, clear
> NETIF_F_GSO_MASK to enforce software segmentation in the stack.
> Add a fallback in mana_start_xmit() to linearize non-GSO SKBs that still
> exceed the SGE limit.
> 
> Also, Add ethtool counter for SKBs linearized
> 
> Co-developed-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
> Signed-off-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
> Signed-off-by: Aditya Garg <gargaditya@...ux.microsoft.com>

Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>