linux-kernel - Re: [PATCH] liveupdate: kho: Enable KHO by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6f3c999-7a17-4c6b-8de7-a380cccdde9f@amazon.com>
Date: Fri, 14 Nov 2025 10:01:20 +0100
From: Alexander Graf <graf@...zon.com>
To: Mike Rapoport <rppt@...nel.org>, Pasha Tatashin
	<pasha.tatashin@...een.com>
CC: <akpm@...ux-foundation.org>, <pratyush@...nel.org>,
	<linux-kernel@...r.kernel.org>, <kexec@...ts.infradead.org>,
	<linux-mm@...ck.org>
Subject: Re: [PATCH] liveupdate: kho: Enable KHO by default


On 14.11.25 08:30, Mike Rapoport wrote:
> On Mon, Nov 10, 2025 at 01:07:15PM -0500, Pasha Tatashin wrote:
>> Upcoming LUO requires KHO for its operations, the requirement to place
>> both KHO=on and liveupdate=on becomes redundant. Set KHO to be enabled
>> by default.
> I though more about this and it seems too much of a change. kho=1 enables
> scratch areas and that significantly changes how free pages are distributed
> in the free lists.
>
> Let's go with a Kconfig option we discussed of-list:
> (this is on top of the current mmotm/mm-nonmm-unstable)
>
>  From 823299d80aa4f7c16ef6cfd798a19e1dfe1a91ab Mon Sep 17 00:00:00 2001
> From: Pasha Tatashin <pasha.tatashin@...een.com>
> Date: Fri, 14 Nov 2025 09:27:47 +0200
> Subject: [PATCH] kho: Allow KHO to be enabled by default
>
> Upcoming LUO requires KHO for its operations, the requirement to place
> both KHO=on and liveupdate=on becomes reduntant. Let's allow KHO to be
> enabled by default, and CONFIG_LIVEUPDATE can select this CONFIG.


Looks much better, yes :). You can also imply this option automatically 
when LUO=y.

Reviewed-by: Alexander Graf <graf@...zon.com>


Alex


>
> Signed-off-by: Pasha Tatashin <pasha.tatashin@...een.com>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> ---
>   kernel/liveupdate/Kconfig          | 8 ++++++++
>   kernel/liveupdate/kexec_handover.c | 2 +-
>   2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/liveupdate/Kconfig b/kernel/liveupdate/Kconfig
> index d7344d347f69..25c9a4d7781f 100644
> --- a/kernel/liveupdate/Kconfig
> +++ b/kernel/liveupdate/Kconfig
> @@ -63,4 +63,12 @@ config KEXEC_HANDOVER_DEBUGFS
>            Also, enables inspecting the KHO fdt trees with the debugfs binary
>            blobs.
>
> +config KEXEC_HANDOVER_ENABLE_DEFAULT
> +       bool "Enable kexec handover by default"
> +       depends on KEXEC_HANDOVER
> +       help
> +         Enable the kexec handover by default. It is equivalent of passing
> +         kho=on via kernel parameter, and can be overwritten to off via
> +         kho=off.
> +
>   endmenu
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index 568cd9fe9aca..23a3df297bb3 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -51,7 +51,7 @@ union kho_page_info {
>
>   static_assert(sizeof(union kho_page_info) == sizeof(((struct page *)0)->private));
>
> -static bool kho_enable __ro_after_init = true;
> +static bool kho_enable __ro_after_init = IS_ENABLED(CONFIG_KEXEC_HANDOVER_ENABLE_DEFAULT);
>
>   bool kho_is_enabled(void)
>   {
> --
> 2.50.1
>
>
>
> --
> Sincerely yours,
> Mike.



Amazon Web Services Development Center Germany GmbH
Tamara-Danz-Str. 13
10243 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Christof Hellmis
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597