linux-kernel - Re: [PATCH 1/2] dt-bindings: bridge: lt8713sx: Add bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bde0d237-b27c-460d-896b-417292f8d4c6@kernel.org>
Date: Sat, 15 Nov 2025 11:40:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vishnu Saini <vishnu.saini@....qualcomm.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Tony <syyang@...tium.com>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, prahlad.valluru@....qualcomm.com,
 qc-display-maintainer@....qualcomm.com,
 Prahlad Valluru <vvalluru@....qualcomm.com>
Subject: Re: [PATCH 1/2] dt-bindings: bridge: lt8713sx: Add bindings

On 15/11/2025 02:03, Vishnu Saini wrote:
> Add bindings for lt8713sx.
> 
> Signed-off-by: Vishnu Saini <vishnu.saini@....qualcomm.com>
> Co-developed-by: Prahlad Valluru <vvalluru@....qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@....qualcomm.com>

Incomplete or incorrectly ordered DCO chain. Please read submitting
patches so you understand what you have to certify.

> ---
>  Documentation/devicetree/bindings/display/bridge/lontium,lt8713sx.yaml | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt8713sx.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt8713sx.yaml
> new file mode 100644
> index 000000000000..3292e149706c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt8713sx.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/lontium,lt8713sx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lontium LT8713SX Type-C/DP1.4 to Type-C/DP1.4/HDMI2.0/DP++ bridge-hub
> +
> +maintainers:
> +  - Tony <syyang@...tium.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The Lontium LT8713SX is a Type-C/DP1.4 to Type-C/DP1.4/HDMI2.0 converter
> +  that integrates one DP input and up to three configurable output interfaces
> +  (DP1.4 / HDMI2.0 / DP++), with SST/MST functionality and audio support.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - lontium,lt8713sx
> +
> +  reg:
> +    maxItems: 1
> +    description: I2C address of the device.

Drop description, obvious thus redundant.

> +
> +  reset-gpios:
> +    description: GPIO connected to active high RESET pin.
> +

Missing ports, supply.

> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c0 {

i2c

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        bridge@4f {
> +            compatible = "lontium,lt8713sx";
> +            reg = <0x4f>;
> +            reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
> +        };
> +    };
> 


Best regards,
Krzysztof