linux-kernel - Re: [PATCH 2/2] drm/bridge: add support for lontium lt8713sx bridge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2f8beed-48e5-4d5b-9bdb-1b13aa598b27@kernel.org>
Date: Sat, 15 Nov 2025 11:42:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vishnu Saini <vishnu.saini@....qualcomm.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Tony <syyang@...tium.com>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, prahlad.valluru@....qualcomm.com,
 qc-display-maintainer@....qualcomm.com,
 Prahlad Valluru <vvalluru@....qualcomm.com>
Subject: Re: [PATCH 2/2] drm/bridge: add support for lontium lt8713sx bridge
 driver

On 15/11/2025 02:03, Vishnu Saini wrote:
> The lt8713sx is a Type-C/DP1.4 to Type-C/DP1.4/HDMI2.0 converter,
> with three configurable DP1.4/HDMI2.0/DP++ output interfaces and
> audio output interface.
> 
> Driver is required for firmware upgrade in the bridge chip.
> 
> Signed-off-by: Vishnu Saini <vishnu.saini@....qualcomm.com>
> Co-developed-by: Prahlad Valluru <vvalluru@....qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@....qualcomm.com>
> ---



> +static int lt8713sx_gpio_init(struct lt8713sx *lt8713sx)
> +{
> +	struct device *dev = lt8713sx->dev;
> +
> +	lt8713sx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> +	if (IS_ERR(lt8713sx->reset_gpio)) {
> +		dev_err(dev, "failed to acquire reset gpio\n");
> +		return PTR_ERR(lt8713sx->reset_gpio);
> +	}
> +
> +	/* power enable gpio */
> +	lt8713sx->enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH);
> +	if (IS_ERR(lt8713sx->enable_gpio)) {
> +		dev_err(dev, "failed to acquire enable gpio\n");

Syntax is return dev_err_probe. In multiple other places as well. You
need to handle deferred probe.

Best regards,
Krzysztof