linux-kernel - Re: [PATCH v2 2/2] iio: accel: adxl380: add support for ADXL318 and ADXL319

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251115171217.4f9d1d12@jic23-huawei>
Date: Sat, 15 Nov 2025 17:12:17 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <Michael.Hennerich@...log.com>,
 <ramona.gradinariu@...log.com>, <antoniu.miclaus@...log.com>,
 <dlechner@...libre.com>, <nuno.sa@...log.com>, <andy@...nel.org>,
 <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>, Andy
 Shevchenko <andriy.shevchenko@...el.com>
Subject: Re: [PATCH v2 2/2] iio: accel: adxl380: add support for ADXL318 and
 ADXL319

On Fri, 14 Nov 2025 19:14:02 -0300
Jonathan Santos <Jonathan.Santos@...log.com> wrote:

> The ADXL318 and ADXL319 are low noise density, low power, 3-axis
> accelerometers based on ADXL380 and ADXL382, respectively. The main
> difference between the new parts and the existing ones are the absence
> of interrupts and events like tap detection, activity/inactivity, and
> free-fall detection.
> 
> Other differences in the new parts are fewer power modes, basically
> allowing only idle and measurement modes, and the removal of the 12-bit
> SAR ADC path for the 3-axis signals (known as lower signal chain),
> being excluisive for the temperature sensor in the ADXL318/319.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> Signed-off-by: Jonathan Santos <Jonathan.Santos@...log.com>

One tiny thing I'll tweak whilst applying.   Applied to the togreg
branch of iio.git which will go out initially as testing.

Thanks,

Jonathan



>  static const unsigned int adxl380_th_reg_high_addr[2] = {
>  	[ADXL380_ACTIVITY] = ADXL380_THRESH_ACT_H_REG,
>  	[ADXL380_INACTIVITY] = ADXL380_THRESH_INACT_H_REG,
> @@ -276,9 +243,14 @@ static int adxl380_set_measure_en(struct adxl380_state *st, bool en)
>  		if (ret)
>  			return ret;
>  
> -		/* Activity/ Inactivity detection available only in VLP/ULP mode */
> -		if (FIELD_GET(ADXL380_ACT_EN_MSK, act_inact_ctl) ||
> -		    FIELD_GET(ADXL380_INACT_EN_MSK, act_inact_ctl))
> +		/*
> +		 * Activity/Inactivity detection available only in VLP/ULP
> +		 * mode and for devices that support low power modes. Otherwise
> +		 * go straight to measure mode (same bits as ADXL380_OP_MODE_HP).
> +		 */
> +		if (st->chip_info->has_low_power &&
> +		    (FIELD_GET(ADXL380_ACT_EN_MSK, act_inact_ctl) ||
> +		    FIELD_GET(ADXL380_INACT_EN_MSK, act_inact_ctl)))

Looks like this is aligned one space before where it should be.

>  			op_mode = ADXL380_OP_MODE_VLP;