linux-kernel - Re: [PATCH] iio: adc: ad7280a: handle spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251115171455.7564a367@jic23-huawei>
Date: Sat, 15 Nov 2025 17:14:55 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, David
 Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Greg Kroah-Hartman
 <gregkh@...e.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH] iio: adc: ad7280a: handle spi_setup() errors in probe()

On Fri, 14 Nov 2025 13:27:04 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> On 11/14, Pavel Zhigulin wrote:
> > The probe() function ignored the return value of spi_setup(), leaving SPI
> > configuration failures undetected. If spi_setup() fails, the driver should
> > stop initialization and propagate the error to the caller.
> > 
> > Add proper error handling: check the return value of spi_setup() and return
> > it on failure.
> > 
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > 
> > Fixes: 2051f25d2a26 ("iio: adc: New driver for AD7280A Lithium Ion Battery Monitoring System")
> > Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>  
> 
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt@...log.com>
> 
> As patch suggestion, we could also have
>   spi-cpha: true
> in ad7280a dt-binding.
That would make sense as a follow up.

Applied this to the fixes-togreg branch of iio.git. Given point in cycle
this may well wait until the merge window.

Thanks,

Jonathan

> 
> Thanks,
> Marcelo
> 
> > ---
> >  drivers/iio/adc/ad7280a.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad7280a.c b/drivers/iio/adc/ad7280a.c
> > index dda2986ccda0..63fceb239bd8 100644
> > --- a/drivers/iio/adc/ad7280a.c
> > +++ b/drivers/iio/adc/ad7280a.c
> > @@ -1024,7 +1024,9 @@ static int ad7280_probe(struct spi_device *spi)
> > 
> >  	st->spi->max_speed_hz = AD7280A_MAX_SPI_CLK_HZ;
> >  	st->spi->mode = SPI_MODE_1;
> > -	spi_setup(st->spi);
> > +	ret = spi_setup(st->spi);
> > +	if (ret < 0)
> > +		return ret;
> > 
> >  	st->ctrl_lb = FIELD_PREP(AD7280A_CTRL_LB_ACQ_TIME_MSK, st->acquisition_time) |
> >  		FIELD_PREP(AD7280A_CTRL_LB_THERMISTOR_MSK, st->thermistor_term_en);
> > --
> > 2.43.0
> > 
> >   
>