linux-kernel - Re: [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6918da93.df0a0220.10a972.69d2@mx.google.com>
Date: Sat, 15 Nov 2025 20:54:52 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Chukun Pan <amadeus@....edu.cn>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	angelogioacchino.delregno@...labora.com,
	Sean Wang <sean.wang@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue

On Sat, Nov 15, 2025 at 06:00:00PM +0800, Chukun Pan wrote:
> The blamed commit made the following changes:
> 
> -#define PINCTRL_FUNC_DESC(id)...
> -		.desc = PINCTRL_PINFUNCTION(#id, ...
> +#define PINCTRL_FUNC_DESC(id, table)...
> +		.desc = PINCTRL_PINFUNCTION(#id, ...
> 
> -	PINCTRL_FUNC_DESC(pon)...
> +	PINCTRL_FUNC_DESC("pon", pon)...
> 
> It's clear that the id of funcs doesn't match the definition.
> Remove redundant #string from the definition to fix this issue:
> pinctrl-airoha ...: invalid function mdio in map table
> 
> Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>

Acked-by: Christian Marangi <ansuelsmth@...il.com>

> ---
>  drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> index bfcedc7f920b..18c952e44229 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> @@ -35,7 +35,7 @@
>  
>  #define PINCTRL_FUNC_DESC(id, table)					\
>  	{								\
> -		.desc = PINCTRL_PINFUNCTION(#id, table##_groups,	\
> +		.desc = PINCTRL_PINFUNCTION(id, table##_groups,	\
>  					    ARRAY_SIZE(table##_groups)),\
>  		.groups = table##_func_group,				\
>  		.group_size = ARRAY_SIZE(table##_func_group),		\
> -- 
> 2.25.1
> 

-- 
	Ansuel