[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdbMPGL=s7gmQsRTNpzdBanWHRX857bcg0Jiu0Zfp=hSyg@mail.gmail.com>
Date: Wed, 19 Nov 2025 00:02:56 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Chukun Pan <amadeus@....edu.cn>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
angelogioacchino.delregno@...labora.com,
Christian Marangi <ansuelsmth@...il.com>, Sean Wang <sean.wang@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue
On Sat, Nov 15, 2025 at 11:00 AM Chukun Pan <amadeus@....edu.cn> wrote:
> The blamed commit made the following changes:
>
> -#define PINCTRL_FUNC_DESC(id)...
> - .desc = PINCTRL_PINFUNCTION(#id, ...
> +#define PINCTRL_FUNC_DESC(id, table)...
> + .desc = PINCTRL_PINFUNCTION(#id, ...
>
> - PINCTRL_FUNC_DESC(pon)...
> + PINCTRL_FUNC_DESC("pon", pon)...
>
> It's clear that the id of funcs doesn't match the definition.
> Remove redundant #string from the definition to fix this issue:
> pinctrl-airoha ...: invalid function mdio in map table
>
> Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>
Patch applied!
Yours,
Linus Walleij
Powered by blists - more mailing lists