linux-kernel - RE: [PATCH v3 20/21] scsi: snic: Switch to use %ptSp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
 <SJ0PR11MB58960101609D15FB8F6FB5B2C3CBA@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Sat, 15 Nov 2025 20:27:19 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Corey Minyard
	<corey@...yard.net>, Christian König
	<christian.koenig@....com>, "Dr. David Alan Gilbert" <linux@...blig.org>,
	Alex Deucher <alexander.deucher@....com>, Thomas Zimmermann
	<tzimmermann@...e.de>, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	Rob Clark <robin.clark@....qualcomm.com>, Matthew Brost
	<matthew.brost@...el.com>, Ulf Hansson <ulf.hansson@...aro.org>, Aleksandr
 Loktionov <aleksandr.loktionov@...el.com>, Vitaly Lifshits
	<vitaly.lifshits@...el.com>, Manivannan Sadhasivam <mani@...nel.org>, Niklas
 Cassel <cassel@...nel.org>, Calvin Owens <calvin@...nvd.org>, Vadim Fedorenko
	<vadim.fedorenko@...ux.dev>, Sagi Maimon <maimon.sagi@...il.com>, "Martin K.
 Petersen" <martin.petersen@...cle.com>, Hans Verkuil
	<hverkuil+cisco@...nel.org>, Casey Schaufler <casey@...aufler-ca.com>, Steven
 Rostedt <rostedt@...dmis.org>, Petr Mladek <pmladek@...e.com>, Viacheslav
 Dubeyko <Slava.Dubeyko@....com>, Max Kellermann <max.kellermann@...os.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"openipmi-developer@...ts.sourceforge.net"
	<openipmi-developer@...ts.sourceforge.net>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linaro-mm-sig@...ts.linaro.org"
	<linaro-mm-sig@...ts.linaro.org>, "amd-gfx@...ts.freedesktop.org"
	<amd-gfx@...ts.freedesktop.org>, "linux-arm-msm@...r.kernel.org"
	<linux-arm-msm@...r.kernel.org>, "freedreno@...ts.freedesktop.org"
	<freedreno@...ts.freedesktop.org>, "intel-xe@...ts.freedesktop.org"
	<intel-xe@...ts.freedesktop.org>, "linux-mmc@...r.kernel.org"
	<linux-mmc@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "linux-s390@...r.kernel.org"
	<linux-s390@...r.kernel.org>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>, "ceph-devel@...r.kernel.org"
	<ceph-devel@...r.kernel.org>, "linux-trace-kernel@...r.kernel.org"
	<linux-trace-kernel@...r.kernel.org>
CC: Rasmus Villemoes <linux@...musvillemoes.dk>, Sergey Senozhatsky
	<senozhatsky@...omium.org>, Jonathan Corbet <corbet@....net>, Sumit Semwal
	<sumit.semwal@...aro.org>, Gustavo Padovan <gustavo@...ovan.org>, David
 Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Dmitry Baryshkov <lumag@...nel.org>, Abhinav Kumar
	<abhinav.kumar@...ux.dev>, Jessica Zhang <jesszhan0024@...il.com>, Sean Paul
	<sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>, Konrad
 Dybcio <konradybcio@...nel.org>, Lucas De Marchi <lucas.demarchi@...el.com>,
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>, Vladimir Oltean <olteanv@...il.com>,
	Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Narsimhulu
 Musini (nmusini)" <nmusini@...co.com>, Paolo Abeni <pabeni@...hat.com>, Tony
 Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>, Krzysztof Wilczyński
	<kwilczynski@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>, Bjorn
 Helgaas <bhelgaas@...gle.com>, Rodolfo Giometti <giometti@...eenne.com>,
	Jonathan Lemon <jonathan.lemon@...il.com>, Richard Cochran
	<richardcochran@...il.com>, Stefan Haberland <sth@...ux.ibm.com>, Jan
 Hoeppner <hoeppner@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle
	<svens@...ux.ibm.com>, "Satish Kharat (satishkh)" <satishkh@...co.com>,
	"Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>, "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Xiubo
 Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>, Masami Hiramatsu
	<mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>, "Gian Carlo Boffa (gcboffa)"
	<gcboffa@...co.com>, "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>
Subject: RE: [PATCH v3 20/21] scsi: snic: Switch to use %ptSp

On Thursday, November 13, 2025 6:33 AM, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>
> Use %ptSp instead of open coded variants to print content of
> struct timespec64 in human readable format.
>
> Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/scsi/snic/snic_debugfs.c | 10 ++++------
> drivers/scsi/snic/snic_trc.c     |  5 ++---
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/snic/snic_debugfs.c b/drivers/scsi/snic/snic_debugfs.c
> index 9dd975b36b5b..edf3e5ef28a6 100644
> --- a/drivers/scsi/snic/snic_debugfs.c
> +++ b/drivers/scsi/snic/snic_debugfs.c
> @@ -282,8 +282,8 @@ snic_stats_show(struct seq_file *sfp, void *data)
> jiffies_to_timespec64(stats->misc.last_ack_time, &last_ack_tms);
>
> seq_printf(sfp,
> -                "Last ISR Time               : %llu (%8llu.%09lu)\n"
> -                "Last Ack Time               : %llu (%8llu.%09lu)\n"
> +                "Last ISR Time               : %llu (%ptSp)\n"
> +                "Last Ack Time               : %llu (%ptSp)\n"
> "Ack ISRs                    : %llu\n"
> "IO Cmpl ISRs                : %llu\n"
> "Err Notify ISRs             : %llu\n"
> @@ -298,10 +298,8 @@ snic_stats_show(struct seq_file *sfp, void *data)
> "Queue Ramp Down             : %lld\n"
> "Queue Last Queue Depth      : %lld\n"
> "Target Not Ready            : %lld\n",
> -                (u64) stats->misc.last_isr_time,
> -                last_isr_tms.tv_sec, last_isr_tms.tv_nsec,
> -                (u64)stats->misc.last_ack_time,
> -                last_ack_tms.tv_sec, last_ack_tms.tv_nsec,
> +                (u64) stats->misc.last_isr_time, &last_isr_tms,
> +                (u64) stats->misc.last_ack_time, &last_ack_tms,
> (u64) atomic64_read(&stats->misc.ack_isr_cnt),
> (u64) atomic64_read(&stats->misc.cmpl_isr_cnt),
> (u64) atomic64_read(&stats->misc.errnotify_isr_cnt),
> diff --git a/drivers/scsi/snic/snic_trc.c b/drivers/scsi/snic/snic_trc.c
> index c2e5ab7e976c..6bad1ea9a6a7 100644
> --- a/drivers/scsi/snic/snic_trc.c
> +++ b/drivers/scsi/snic/snic_trc.c
> @@ -56,9 +56,8 @@ snic_fmt_trc_data(struct snic_trc_data *td, char *buf, int buf_sz)
> jiffies_to_timespec64(td->ts, &tmspec);
>
> len += snprintf(buf, buf_sz,
> -                     "%llu.%09lu %-25s %3d %4x %16llx %16llx %16llx %16llx %16llx\n",
> -                     tmspec.tv_sec,
> -                     tmspec.tv_nsec,
> +                     "%ptSp %-25s %3d %4x %16llx %16llx %16llx %16llx %16llx\n",
> +                     &tmspec,
> td->fn,
> td->hno,
> td->tag,
> --
> 2.50.1
>
>

Thanks for the change, Andy.

Acked-by: Karan Tilak Kumar <kartilak@...co.com>

Regards,
Karan