linux-kernel - Re: [PATCH v3 13/21] mmc: mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPDyKFotmQyHzBim-8nib-KVvQaQgA_ELbgdC_Q4Y95-GrvRSw@mail.gmail.com>
Date: Mon, 17 Nov 2025 12:00:38 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Corey Minyard <corey@...yard.net>, Christian König <christian.koenig@....com>, 
	"Dr. David Alan Gilbert" <linux@...blig.org>, Alex Deucher <alexander.deucher@....com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
	Rob Clark <robin.clark@....qualcomm.com>, Matthew Brost <matthew.brost@...el.com>, 
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>, Vitaly Lifshits <vitaly.lifshits@...el.com>, 
	Manivannan Sadhasivam <mani@...nel.org>, Niklas Cassel <cassel@...nel.org>, Calvin Owens <calvin@...nvd.org>, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Sagi Maimon <maimon.sagi@...il.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, Karan Tilak Kumar <kartilak@...co.com>, 
	Hans Verkuil <hverkuil+cisco@...nel.org>, Casey Schaufler <casey@...aufler-ca.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Petr Mladek <pmladek@...e.com>, 
	Viacheslav Dubeyko <Slava.Dubeyko@....com>, Max Kellermann <max.kellermann@...os.com>, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	openipmi-developer@...ts.sourceforge.net, linux-media@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org, 
	amd-gfx@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org, 
	freedreno@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org, 
	linux-mmc@...r.kernel.org, netdev@...r.kernel.org, 
	intel-wired-lan@...ts.osuosl.org, linux-pci@...r.kernel.org, 
	linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org, 
	linux-staging@...ts.linux.dev, ceph-devel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, 
	Rasmus Villemoes <linux@...musvillemoes.dk>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Jonathan Corbet <corbet@....net>, Sumit Semwal <sumit.semwal@...aro.org>, 
	Gustavo Padovan <gustavo@...ovan.org>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Dmitry Baryshkov <lumag@...nel.org>, Abhinav Kumar <abhinav.kumar@...ux.dev>, 
	Jessica Zhang <jesszhan0024@...il.com>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Lucas De Marchi <lucas.demarchi@...el.com>, 
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>, 
	Rodrigo Vivi <rodrigo.vivi@...el.com>, Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>, 
	Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Rodolfo Giometti <giometti@...eenne.com>, Jonathan Lemon <jonathan.lemon@...il.com>, 
	Richard Cochran <richardcochran@...il.com>, Stefan Haberland <sth@...ux.ibm.com>, 
	Jan Hoeppner <hoeppner@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, 
	Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>, 
	Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, 
	Satish Kharat <satishkh@...co.com>, Sesidhar Baddela <sebaddel@...co.com>, 
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3 13/21] mmc: mmc_test: Switch to use %ptSp

On Thu, 13 Nov 2025 at 16:03, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Use %ptSp instead of open coded variants to print content of
> struct timespec64 in human readable format.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  drivers/mmc/core/mmc_test.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index a74089df4547..01d1e62c2ce7 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -586,14 +586,11 @@ static void mmc_test_print_avg_rate(struct mmc_test_card *test, uint64_t bytes,
>         rate = mmc_test_rate(tot, &ts);
>         iops = mmc_test_rate(count * 100, &ts); /* I/O ops per sec x 100 */
>
> -       pr_info("%s: Transfer of %u x %u sectors (%u x %u%s KiB) took "
> -                        "%llu.%09u seconds (%u kB/s, %u KiB/s, "
> -                        "%u.%02u IOPS, sg_len %d)\n",
> -                        mmc_hostname(test->card->host), count, sectors, count,
> -                        sectors >> 1, (sectors & 1 ? ".5" : ""),
> -                        (u64)ts.tv_sec, (u32)ts.tv_nsec,
> -                        rate / 1000, rate / 1024, iops / 100, iops % 100,
> -                        test->area.sg_len);
> +       pr_info("%s: Transfer of %u x %u sectors (%u x %u%s KiB) took %ptSp seconds (%u kB/s, %u KiB/s, %u.%02u IOPS, sg_len %d)\n",
> +               mmc_hostname(test->card->host), count, sectors, count,
> +               sectors >> 1, (sectors & 1 ? ".5" : ""), &ts,
> +               rate / 1000, rate / 1024, iops / 100, iops % 100,
> +               test->area.sg_len);
>
>         mmc_test_save_transfer_result(test, count, sectors, ts, rate, iops);
>  }
> @@ -3074,10 +3071,9 @@ static int mtf_test_show(struct seq_file *sf, void *data)
>                 seq_printf(sf, "Test %d: %d\n", gr->testcase + 1, gr->result);
>
>                 list_for_each_entry(tr, &gr->tr_lst, link) {
> -                       seq_printf(sf, "%u %d %llu.%09u %u %u.%02u\n",
> -                               tr->count, tr->sectors,
> -                               (u64)tr->ts.tv_sec, (u32)tr->ts.tv_nsec,
> -                               tr->rate, tr->iops / 100, tr->iops % 100);
> +                       seq_printf(sf, "%u %d %ptSp %u %u.%02u\n",
> +                                  tr->count, tr->sectors, &tr->ts, tr->rate,
> +                                  tr->iops / 100, tr->iops % 100);
>                 }
>         }
>
> --
> 2.50.1
>