linux-kernel - Re: [PATCH] irqchip: Fix error handling in qcom_mpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87seed972b.ffs@tglx>
Date: Sun, 16 Nov 2025 19:16:28 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Ma Ke <make24@...as.ac.cn>, maz@...nel.org, shawn.guo@...aro.org
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, Ma Ke
 <make24@...as.ac.cn>, stable@...r.kernel.org
Subject: Re: [PATCH] irqchip: Fix error handling in qcom_mpm_init

On Sun, Nov 16 2025 at 16:16, Ma Ke wrote:

> of_find_device_by_node() increments the reference count but it's never
> decremented, preventing proper device cleanup. Add put_device()
> properly to ensure references released before function return.
>
> Found by code review.

By whom? You sent 7 patches today which touch random parts of the
kernel:

  [PATCH] irqchip: Fix error handling in qcom_mpm_init
  [PATCH] phy: HiSilicon: Fix error handling in hi3670_pcie_get_resources_from_pcie
  [PATCH] ASoC: codecs: wcd937x: Fix error handling in wcd937x codec driver
  [PATCH] ASoC: codecs: Fix error handling in pm4125 audio codec driver
  [PATCH] powerpc/warp: Fix error handling in pika_dtm_thread
  [PATCH] USB: Fix error handling in gadget driver
  [PATCH] USB: ohci-nxp: Fix error handling in ohci-hcd-nxp driver

and in all of them you claim to have found them by code review.

Why do I have doubts especially when I look at your email address?

Thanks,

        tglx