linux-kernel - Re: [PATCH] irqchip: Fix error handling in qcom_mpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251117004733.14976-1-make24@iscas.ac.cn>
Date: Mon, 17 Nov 2025 08:47:33 +0800
From: Ma Ke <make24@...as.ac.cn>
To: tglx@...utronix.de
Cc: akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	make24@...as.ac.cn,
	maz@...nel.org,
	shawn.guo@...aro.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] irqchip: Fix error handling in qcom_mpm_init

On Mon, Nov 17 2025 at 02:16, Thomas Gleixner wrote:
> On Sun, Nov 16 2025 at 16:16, Ma Ke wrote:
> 
> > of_find_device_by_node() increments the reference count but it's never
> > decremented, preventing proper device cleanup. Add put_device()
> > properly to ensure references released before function return.
> >
> > Found by code review.
> 
> By whom? You sent 7 patches today which touch random parts of the
> kernel:
> 
>   [PATCH] irqchip: Fix error handling in qcom_mpm_init
>   [PATCH] phy: HiSilicon: Fix error handling in hi3670_pcie_get_resources_from_pcie
>   [PATCH] ASoC: codecs: wcd937x: Fix error handling in wcd937x codec driver
>   [PATCH] ASoC: codecs: Fix error handling in pm4125 audio codec driver
>   [PATCH] powerpc/warp: Fix error handling in pika_dtm_thread
>   [PATCH] USB: Fix error handling in gadget driver
>   [PATCH] USB: ohci-nxp: Fix error handling in ohci-hcd-nxp driver
> 
> and in all of them you claim to have found them by code review.
> 
> Why do I have doubts especially when I look at your email address?
> 
> Thanks,
> 
>         tglx
Hi,

Thank you for your note. I can confirm these issues were found through
manual audit. I accumulated these findings over time and submitted 
them in a single batch during my spare time. This is a good-faith 
effort to contribute to the kernel by fixing what I found.

Best regards,
Ma Ke