linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-next v5 12/15] ixd: add basic driver framework for Intel(R) Control Plane Function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aRsz-fBHLmrbJlrf@soc-5CG4396X81.clients.intel.com>
Date: Mon, 17 Nov 2025 15:40:57 +0100
From: Larysa Zaremba <larysa.zaremba@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Samudrala, Sridhar"
	<sridhar.samudrala@...el.com>, "Singhai, Anjali" <anjali.singhai@...el.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, "Fijalkowski,
 Maciej" <maciej.fijalkowski@...el.com>, "Tantilov, Emil S"
	<emil.s.tantilov@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>,
	"Hay, Joshua A" <joshua.a.hay@...el.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, "Shanmugam, Jayaprakash"
	<jayaprakash.shanmugam@...el.com>, "Wochtman, Natalia"
	<natalia.wochtman@...el.com>, Jiri Pirko <jiri@...nulli.us>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Jonathan Corbet <corbet@....net>, Richard Cochran
	<richardcochran@...il.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 12/15] ixd: add basic
 driver framework for Intel(R) Control Plane Function

On Mon, Nov 17, 2025 at 03:18:32PM +0100, Loktionov, Aleksandr wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> > Of Larysa Zaremba
> > Sent: Monday, November 17, 2025 2:49 PM
> > To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> > <anthony.l.nguyen@...el.com>
> > Cc: Lobakin, Aleksander <aleksander.lobakin@...el.com>; Samudrala,
> > Sridhar <sridhar.samudrala@...el.com>; Singhai, Anjali
> > <anjali.singhai@...el.com>; Michal Swiatkowski
> > <michal.swiatkowski@...ux.intel.com>; Zaremba, Larysa
> > <larysa.zaremba@...el.com>; Fijalkowski, Maciej
> > <maciej.fijalkowski@...el.com>; Tantilov, Emil S
> > <emil.s.tantilov@...el.com>; Chittim, Madhu <madhu.chittim@...el.com>;
> > Hay, Joshua A <joshua.a.hay@...el.com>; Keller, Jacob E
> > <jacob.e.keller@...el.com>; Shanmugam, Jayaprakash
> > <jayaprakash.shanmugam@...el.com>; Wochtman, Natalia
> > <natalia.wochtman@...el.com>; Jiri Pirko <jiri@...nulli.us>; David S.
> > Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
> > Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>;
> > Simon Horman <horms@...nel.org>; Jonathan Corbet <corbet@....net>;
> > Richard Cochran <richardcochran@...il.com>; Kitszel, Przemyslaw
> > <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> > netdev@...r.kernel.org; linux-doc@...r.kernel.org; linux-
> > kernel@...r.kernel.org
> > Subject: [Intel-wired-lan] [PATCH iwl-next v5 12/15] ixd: add basic
> > driver framework for Intel(R) Control Plane Function
> > 
> > Add module register and probe functionality. Add the required support
> > to register IXD PCI driver, as well as probe and remove call backs.
> > Enable the PCI device and request the kernel to reserve the memory
> > resources that will be used by the driver. Finally map the BAR0
> > address space.
> > 
> > For now, use devm_alloc() to allocate adapter, as it requires the
> > least amount of code. In a later commit, it will be replaced with a
> > devlink alternative.
> > 
> > Co-developed-by: Amritha Nambiar <amritha.nambiar@...el.com>
> > Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>
> > Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
> > ---
> >  .../device_drivers/ethernet/index.rst         |   1 +
> >  .../device_drivers/ethernet/intel/ixd.rst     |  39 ++++++
> >  drivers/net/ethernet/intel/Kconfig            |   2 +
> >  drivers/net/ethernet/intel/Makefile           |   1 +
> >  drivers/net/ethernet/intel/ixd/Kconfig        |  13 ++
> >  drivers/net/ethernet/intel/ixd/Makefile       |   8 ++
> >  drivers/net/ethernet/intel/ixd/ixd.h          |  28 +++++
> >  drivers/net/ethernet/intel/ixd/ixd_lan_regs.h |  28 +++++
> >  drivers/net/ethernet/intel/ixd/ixd_main.c     | 112
> > ++++++++++++++++++
> >  9 files changed, 232 insertions(+)
> >  create mode 100644
> > Documentation/networking/device_drivers/ethernet/intel/ixd.rst
> >  create mode 100644 drivers/net/ethernet/intel/ixd/Kconfig
> >  create mode 100644 drivers/net/ethernet/intel/ixd/Makefile
> >  create mode 100644 drivers/net/ethernet/intel/ixd/ixd.h
> >  create mode 100644 drivers/net/ethernet/intel/ixd/ixd_lan_regs.h
> >  create mode 100644 drivers/net/ethernet/intel/ixd/ixd_main.c
> > 
> > diff --git
> > a/Documentation/networking/device_drivers/ethernet/index.rst
> > b/Documentation/networking/device_drivers/ethernet/index.rst
> > index bcc02355f828..b73d13a2f748 100644
> > --- a/Documentation/networking/device_drivers/ethernet/index.rst
> > +++ b/Documentation/networking/device_drivers/ethernet/index.rst
> > @@ -38,6 +38,7 @@ Contents:
> >     intel/igbvf
> >     intel/ixgbe
> >     intel/ixgbevf
> > +   intel/ixd
> >     intel/i40e
> >     intel/iavf
> >     intel/ice
> > diff --git
> > a/Documentation/networking/device_drivers/ethernet/intel/ixd.rst
> > b/Documentation/networking/device_drivers/ethernet/intel/ixd.rst
> > new file mode 100644
> > index 000000000000..1387626e5d20
> > --- /dev/null
> > +++ b/Documentation/networking/device_drivers/ethernet/intel/ixd.rst
> > @@ -0,0 +1,39 @@
> > +.. SPDX-License-Identifier: GPL-2.0+
> 
> ...
> 
> > +/**
> > + * ixd_probe - probe a CPF PCI device
> > + * @pdev: corresponding PCI device
> > + * @ent: entry in ixd_pci_tbl
> > + *
> > + * Returns: %0 on success, negative errno code on failure  */ static
> > +int ixd_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> > {
> > +	struct ixd_adapter *adapter;
> > +	int err;
> > +
> > +	adapter = devm_kzalloc(&pdev->dev, sizeof(*adapter),
> > GFP_KERNEL);
> > +	if (!adapter)
> > +		return -ENOMEM;
> > +	adapter->hw.pdev = pdev;
> > +	INIT_LIST_HEAD(&adapter->hw.mmio_list);
> > +
> > +	err = libie_pci_init_dev(pdev);
> > +	if (err)
> > +		return err;
> On libie_pci_init_dev() failure, no cleanup of mapped regions.

No regions are mapped at this point. If you mean requested regions, they are 
cleaned up automatically by the means of pcim_*.

> 
> > +
> > +	pci_set_drvdata(pdev, adapter);
> > +
> > +	return ixd_iomap_regions(adapter);
> > +}
> It looks like missed pci_set_master() in probe.

This is done by libie_pci_init_dev().

> After successful init, DMA may fail without enabling bus mastering.
> 
> > +
> > +static const struct pci_device_id ixd_pci_tbl[] = {
> > +	{ PCI_VDEVICE(INTEL, IXD_DEV_ID_CPF) },
> > +	{ }
> > +};
> > +MODULE_DEVICE_TABLE(pci, ixd_pci_tbl);
> > +
> > +static struct pci_driver ixd_driver = {
> > +	.name			= KBUILD_MODNAME,
> > +	.id_table		= ixd_pci_tbl,
> > +	.probe			= ixd_probe,
> > +	.remove			= ixd_remove,
> > +	.shutdown		= ixd_shutdown,
> > +};
> > +module_pci_driver(ixd_driver);
> > --
> > 2.47.0
>