| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aRs0aeCUYLxPbwTd@soc-5CG4396X81.clients.intel.com>
Date: Mon, 17 Nov 2025 15:42:49 +0100
From: Larysa Zaremba <larysa.zaremba@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Lobakin, Aleksander"
<aleksander.lobakin@...el.com>, "Samudrala, Sridhar"
<sridhar.samudrala@...el.com>, "Singhai, Anjali" <anjali.singhai@...el.com>,
Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, "Fijalkowski,
Maciej" <maciej.fijalkowski@...el.com>, "Tantilov, Emil S"
<emil.s.tantilov@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>,
"Hay, Joshua A" <joshua.a.hay@...el.com>, "Keller, Jacob E"
<jacob.e.keller@...el.com>, "Shanmugam, Jayaprakash"
<jayaprakash.shanmugam@...el.com>, "Wochtman, Natalia"
<natalia.wochtman@...el.com>, Jiri Pirko <jiri@...nulli.us>, "David S.
Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
<horms@...nel.org>, Jonathan Corbet <corbet@....net>, Richard Cochran
<richardcochran@...il.com>, "Kitszel, Przemyslaw"
<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 13/15] ixd: add reset
checks and initialize the mailbox
On Mon, Nov 17, 2025 at 03:21:06PM +0100, Loktionov, Aleksandr wrote:
>
>
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> > Of Larysa Zaremba
> > Sent: Monday, November 17, 2025 2:49 PM
> > To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> > <anthony.l.nguyen@...el.com>
> > Cc: Lobakin, Aleksander <aleksander.lobakin@...el.com>; Samudrala,
> > Sridhar <sridhar.samudrala@...el.com>; Singhai, Anjali
> > <anjali.singhai@...el.com>; Michal Swiatkowski
> > <michal.swiatkowski@...ux.intel.com>; Zaremba, Larysa
> > <larysa.zaremba@...el.com>; Fijalkowski, Maciej
> > <maciej.fijalkowski@...el.com>; Tantilov, Emil S
> > <emil.s.tantilov@...el.com>; Chittim, Madhu <madhu.chittim@...el.com>;
> > Hay, Joshua A <joshua.a.hay@...el.com>; Keller, Jacob E
> > <jacob.e.keller@...el.com>; Shanmugam, Jayaprakash
> > <jayaprakash.shanmugam@...el.com>; Wochtman, Natalia
> > <natalia.wochtman@...el.com>; Jiri Pirko <jiri@...nulli.us>; David S.
> > Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
> > Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>;
> > Simon Horman <horms@...nel.org>; Jonathan Corbet <corbet@....net>;
> > Richard Cochran <richardcochran@...il.com>; Kitszel, Przemyslaw
> > <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> > netdev@...r.kernel.org; linux-doc@...r.kernel.org; linux-
> > kernel@...r.kernel.org
> > Subject: [Intel-wired-lan] [PATCH iwl-next v5 13/15] ixd: add reset
> > checks and initialize the mailbox
> >
> > At the end of the probe, trigger hard reset, initialize and schedule
> > the after-reset task. If the reset is complete in a pre-determined
> > time, initialize the default mailbox, through which other resources
> > will be negotiated.
> >
> > Co-developed-by: Amritha Nambiar <amritha.nambiar@...el.com>
> > Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>
> > Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
> > ---
> > drivers/net/ethernet/intel/ixd/Kconfig | 1 +
> > drivers/net/ethernet/intel/ixd/Makefile | 2 +
> > drivers/net/ethernet/intel/ixd/ixd.h | 28 +++-
> > drivers/net/ethernet/intel/ixd/ixd_dev.c | 89 +++++++++++
> > drivers/net/ethernet/intel/ixd/ixd_lan_regs.h | 40 +++++
> > drivers/net/ethernet/intel/ixd/ixd_lib.c | 143
> > ++++++++++++++++++
> > drivers/net/ethernet/intel/ixd/ixd_main.c | 32 +++-
> > 7 files changed, 326 insertions(+), 9 deletions(-) create mode
> > 100644 drivers/net/ethernet/intel/ixd/ixd_dev.c
> > create mode 100644 drivers/net/ethernet/intel/ixd/ixd_lib.c
> >
> > diff --git a/drivers/net/ethernet/intel/ixd/Kconfig
> > b/drivers/net/ethernet/intel/ixd/Kconfig
> > index f5594efe292c..24510c50070e 100644
> > --- a/drivers/net/ethernet/intel/ixd/Kconfig
> > +++ b/drivers/net/ethernet/intel/ixd/Kconfig
> > @@ -5,6 +5,7 @@ config IXD
> > tristate "Intel(R) Control Plane Function Support"
> > depends on PCI_MSI
> > select LIBETH
> > + select LIBIE_CP
> > select LIBIE_PCI
> > help
> > This driver supports Intel(R) Control Plane PCI Function diff
>
> ...
>
> > +/**
> > + * ixd_check_reset_complete - Check if the PFR reset is completed
> > + * @adapter: CPF being reset
> > + *
> > + * Return: %true if the register read indicates reset has been
> > finished,
> > + * %false otherwise
> > + */
> > +bool ixd_check_reset_complete(struct ixd_adapter *adapter) {
> > + u32 reg_val, reset_status;
> > + void __iomem *addr;
> > +
> > + addr = libie_pci_get_mmio_addr(&adapter->cp_ctx.mmio_info,
> > + ixd_reset_reg.rstat);
> > + reg_val = readl(addr);
> > + reset_status = reg_val & ixd_reset_reg.rstat_m;
> > +
> > + /* 0xFFFFFFFF might be read if the other side hasn't cleared
> > + * the register for us yet.
> > + */
> > + if (reg_val != 0xFFFFFFFF &&
> > + reset_status == ixd_reset_reg.rstat_ok_v)
> Magic number, I think 0xFFFFFFFF should be ~0U per kernel style.
I believe ~0U depends on the int size, but GENMASK() could work.
>
> > + return true;
> > +
> > + return false;
> > +}
>
> ...
>
> > --
> > 2.47.0
>
Powered by blists - more mailing lists