linux-kernel - Re: [PATCH] r8169: add support for RTL8127ATF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6beb0d4-f65e-4181-80e6-212b0a938a15@lunn.ch>
Date: Mon, 17 Nov 2025 20:37:41 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Fabio Baltieri <fabio.baltieri@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>, nic_swsd@...ltek.com,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8169: add support for RTL8127ATF

> +	if (tp->fiber_mode) {
> +		phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_10baseT_Half_BIT);
> +		phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_10baseT_Full_BIT);
> +		phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_100baseT_Half_BIT);
> +		phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_100baseT_Full_BIT);
> +		phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_2500baseT_Full_BIT);
> +		phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_5000baseT_Full_BIT);

An SFP module can support baseT modes, if the SFP module has a PHY
inside it. But it could also be it is a fibre module with a laser and
so uses 100baseFX, 1000baseX, 2500BaseX, etc.

To do this properly, you need to be able to read the SFP EERPOMs
content, to know what sort of SFP module you have plugged in. Then you
can list the correct modes.

	Andrew