linux-kernel - Re: [PATCH] rust: allow `clippy::disallowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2126d9ee-ccbf-4c50-8e05-b02d186fb1a6@nvidia.com>
Date: Mon, 17 Nov 2025 13:37:41 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Benno Lossin <lossin@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Brendan Higgins <brendan.higgins@...ux.dev>, David Gow
 <davidgow@...gle.com>, rust-for-linux@...r.kernel.org,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>,
 Rae Moar <raemoar63@...il.com>, linux-kselftest@...r.kernel.org,
 kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev
Subject: Re: [PATCH] rust: allow `clippy::disallowed_names` for doctests

On 11/17/25 1:26 PM, Miguel Ojeda wrote:
> On Mon, Nov 17, 2025 at 10:13 PM John Hubbard <jhubbard@...dia.com> wrote:
>>
>> The current set of disallowed names is inherited from clippy's defaults [1],
>> which are "foo", "baz", and "quux". This may be extended via .clipy.toml,
>> which so far has no entries for disallowed names.
> 
> As for this paragraph, I am confused why we would want to add it.
> 
> This isn't about extending the disallowed names or about how the lint
> works in general. It is just about disabling the lint entirely for
> doctests.

Yes. But I still thought some context might help, because it wasn't
obvious at first to me (as a Rust learner).

> 
> So adding that paragraph would make it the commit more confusing.
> 

OK, I'll accept that judgment call. :)

thanks,
-- 
John Hubbard