linux-kernel - Re: [PATCH v5 6/8] media: mediatek: vcodec: fix media device node number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffa2db69d5c43ed2e84d167dfddb10c380a01e16.camel@mediatek.com>
Date: Mon, 17 Nov 2025 06:15:35 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	George Sun (孙林) <George.Sun@...iatek.com>,
	Tiffany Lin (林慧珊) <tiffany.lin@...iatek.com>,
	"nhebert@...omium.org" <nhebert@...omium.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"nicolas.dufresne@...labora.com" <nicolas.dufresne@...labora.com>,
	"hverkuil@...all.nl" <hverkuil@...all.nl>,
	Yunfei Dong (董云飞) <Yunfei.Dong@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	Irui Wang (王瑞) <Irui.Wang@...iatek.com>,
	"robh@...nel.org" <robh@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	Yilong Zhou (周易龙) <Yilong.Zhou@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
	Andrew-CT Chen (陳智迪)
	<Andrew-CT.Chen@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "andrzejtp2010@...il.com" <andrzejtp2010@...il.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>
Subject: Re: [PATCH v5 6/8] media: mediatek: vcodec: fix media device node
 number

On Thu, 2025-11-06 at 09:47 -0500, Nicolas Dufresne wrote:
> Hi,
> 
> fix -> Fix
> 
> Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> > change media register device node number to a correct value
> 
> You already say that in the subject, the description should explain
> why vfd_dec-
> > minor was wrong.
> 
> Nicolas

Dear Nicolas,

I will explain it in the next version.

Thanks.

Regards,
Kyrie
> 	
> 
> > 
> > Fixes: 41f03c673cb7b ("media: mediatek: vcodec: replace pr_* with
> > dev_* for
> > v4l2 debug message")
> > 
> > Signed-off-by: Kyrie Wu <kyrie.wu@...iatek.com>
> > ---
> >  .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c      | 3
> > ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > index fca60e81e3c7..f3e49597602a 100644
> > ---
> > a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > +++
> > b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > @@ -516,7 +516,8 @@ static int mtk_vcodec_probe(struct
> > platform_device *pdev)
> >  			goto err_media_reg;
> >  		}
> >  
> > -		dev_dbg(&pdev->dev, "media registered as /dev/media%d",
> > vfd_dec->minor);
> > +		dev_dbg(&pdev->dev, "media registered as /dev/media%d",
> > +			dev->mdev_dec.devnode->minor);
> >  	}
> >  
> >  	mtk_vcodec_dbgfs_init(dev, false);