linux-kernel - Re: [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dea9519e6b72c12ea15760fc3bd7c7746dbfd5de.camel@mediatek.com>
Date: Mon, 17 Nov 2025 07:36:01 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	George Sun (孙林) <George.Sun@...iatek.com>,
	Tiffany Lin (林慧珊) <tiffany.lin@...iatek.com>,
	"nhebert@...omium.org" <nhebert@...omium.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"nicolas.dufresne@...labora.com" <nicolas.dufresne@...labora.com>,
	"hverkuil@...all.nl" <hverkuil@...all.nl>,
	Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>,
	Yunfei Dong (董云飞) <Yunfei.Dong@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	Irui Wang (王瑞) <Irui.Wang@...iatek.com>,
	"robh@...nel.org" <robh@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	Yilong Zhou (周易龙) <Yilong.Zhou@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
	Andrew-CT Chen (陳智迪)
	<Andrew-CT.Chen@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "andrzejtp2010@...il.com" <andrzejtp2010@...il.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>
Subject: Re: [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail
 for profile2

On Thu, 2025-11-06 at 10:17 -0500, Nicolas Dufresne wrote:
> Hi,
> 
> Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> > The dram addr of vp9 decoder tile number, which use dram mode
> > to set tile information, may reach to 36bits for 4096x2176.
> > It needs to get the highest 4bit of tile buffer address to
> > set tile buffer address.
> 
> An after thought, I don't see any call to
> vb2_dma_contig_set_max_seg_size() or
> dma_set_coherent_mask() with DMA_BIT_MASK(32)/DMA_BIT_MASK(36) in
> this driver.
> How do you control this ?
> 
> Nicolas

Dear Nicolas,

The tile buffer is handled in VCP, not in kernel driver. We only
get the full correct address in kernel.

Thanks.

Regards,
Kyrie
> 
> > 
> > Fixes: 5d418351ca8f1 ("media: mediatek: vcodec: support stateless
> > VP9
> > decoding")
> > 
> > Signed-off-by: Kyrie Wu <kyrie.wu@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@...labora.com>
> > ---
> >  .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c       | 5
> > ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_
> > lat_if.c
> > b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_
> > lat_if.c
> > index d966914db4b9..91c563c049bd 100644
> > ---
> > a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_
> > lat_if.c
> > +++
> > b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_
> > lat_if.c
> > @@ -1156,7 +1156,10 @@ static int
> > vdec_vp9_slice_setup_tile_buffer(struct
> > vdec_vp9_slice_instance *inst
> >  			tiles->size[i][j] = size;
> >  			if (tiles->mi_rows[i]) {
> >  				*tb++ = (size << 3) + ((offset << 3) &
> > 0x7f);
> > -				*tb++ = pa & ~0xf;
> > +				*tb = pa & ~0xf;
> > +				if
> > (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT))
> > +					*tb |= (pa >> 32) & 0xf;
> > +				tb++;
> >  				*tb++ = (pa << 3) & 0x7f;
> >  				mi_row = (tiles->mi_rows[i] - 1) &
> > 0x1ff;
> >  				mi_col = (tiles->mi_cols[j] - 1) &
> > 0x3f;