linux-kernel - Re: [PATCH 2/3] dma: arm-dma350: add support for shared interrupt mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af459551-3f31-4108-9863-c050332cd3b3@cixtech.com>
Date: Mon, 17 Nov 2025 19:52:19 +0800
From: Jun Guo <jun.guo@...tech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, peter.chen@...tech.com,
 fugang.duan@...tech.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, vkoul@...nel.org, ychuang3@...oton.com,
 schung@...oton.com, robin.murphy@....com
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/3] dma: arm-dma350: add support for shared interrupt
 mode



On 11/17/2025 7:44 PM, Krzysztof Kozlowski wrote:
> On 17/11/2025 12:37, Jun Guo wrote:
>>>>         /* Would be nice to have per-channel caps for this... */
>>>>         memset = true;
>>>>         for (int i = 0; i < nchan; i++) {
>>>> @@ -595,10 +683,16 @@ static int d350_probe(struct platform_device *pdev)
>>>>                         dev_warn(dev, "No command link support on channel %d\n", i);
>>>>                         continue;
>>>>                 }
>>>> -             dch->irq = platform_get_irq(pdev, i);
>>>> -             if (dch->irq < 0)
>>>> -                     return dev_err_probe(dev, dch->irq,
>>>> -                                          "Failed to get IRQ for channel %d\n", i);
>>>> +
>>>> +             if (!of_device_is_compatible(pdev->dev.of_node,
>>>> +                                          "cix,sky1-dma-350")) {
>>> No, use driver match data for that. Sprinkling compatibles everywhere
>>> does not scale.
>>>
>> I have another question: by "driver match data", are you referring to
>> the data variable in the struct of_device_id?
> Yes.
> 
OK. Thanks for the reminder.>>> Also, this is in contrary with the 
binding, which did not say your
>>> device has no interrupts.
>> I need to clarify here: the issue with my chip platform is not the lack
>> of interrupts, but that all DMA channels share a single interrupt. The
>> current driver, however, defaults to assigning an individual interrupt
>> for each DMA channel.
> I am speaking about binding, which said that first interrupt is only for
> channel 0. You need to restrict/change it for your variant.
Okay, I see your point. Thanks.