linux-kernel - Re: [PATCH 1/3] dt-bindings: dma: arm-dma350: update DT binding docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08142bd3-4a17-4c4f-88ff-fd81e9941a18@cixtech.com>
Date: Mon, 17 Nov 2025 20:51:59 +0800
From: Jun Guo <jun.guo@...tech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, peter.chen@...tech.com,
 fugang.duan@...tech.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, vkoul@...nel.org, ychuang3@...oton.com,
 schung@...oton.com, robin.murphy@....com
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: dma: arm-dma350: update DT binding docs


On 11/17/2025 3:13 PM, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On 17/11/2025 08:11, Krzysztof Kozlowski wrote:
>> On 17/11/2025 08:07, Jun Guo wrote:
>>>
>>> On 11/17/2025 2:11 PM, Krzysztof Kozlowski wrote:
>>>> On 17/11/2025 02:59, Jun Guo wrote:
>>>>> - Add new compatible strings to the DT binding documents to support
>>>> This is not a list.
>>>>
>>>> Also, subject is completely redundant. Everything is an update. Why are
>>>> you repeating DT binding docs?
>>>>
>>> Thank you. I will incorporate your feedback in the next version.>>   cix
>>> sky1 SoC.
>>>>>
>>>>> Signed-off-by: Jun Guo<jun.guo@...tech.com>
>>>>> ---
>>>> You just broke all existing platforms. Please test your code properly.
>>> The patch includes proper checks. Since this platform is the first user
>>
>> Nah, tests are here incomplete - look at the binding and DTS users...
>> nothing there, so you cannot test it.
>>
>>> of the driver in the current codebase, the change won't affect other
>>> platforms.
>>
>> NAK, and you keep pushing... I just told you it will break everyone,
>> which is obvious from the diff.
> 
> But if that was intentional change of ABI, then could be fine, but you
> must provide in commit msg proper detailed rationale WHY you are
> changing ABI and WHAT is the ABI impact of that change.
> 
I'm not entirely sure if I fully grasped your point, but I also 
identified the potential issue. I've reworked the patch to accommodate 
both the default DTS case with a single compatible string and the 
scenario where platform-specific compatible strings need to be added. 
Could you please review it again and confirm if this aligns with your 
intent?

properties:
   compatible:
     contains:
       enum:
         - cix,sky1-dma-350
         - arm,dma-350

Best regards,
Jun