linux-kernel - Re: [PATCH 3/3] mm/zswap: use %pe to print PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5f92735-0e2b-48e7-9181-04bc058c0bde@web.de>
Date: Tue, 18 Nov 2025 14:20:59 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Sahil Chandna <chandna.sahil@...il.com>, linux-mm@...ck.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Axel Rasmussen <axelrasmussen@...gle.com>,
 Chengming Zhou <chengming.zhou@...ux.dev>,
 David Hildenbrand <david@...hat.com>, Johannes Weiner <hannes@...xchg.org>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Michal Hocko
 <mhocko@...e.com>, Mike Rapoport <rppt@...nel.org>,
 Nhat Pham <nphamcs@...il.com>, Qi Zheng <zhengqi.arch@...edance.com>,
 Shakeel Butt <shakeel.butt@...ux.dev>, Suren Baghdasaryan
 <surenb@...gle.com>, Vlastimil Babka <vbabka@...e.cz>,
 Wei Xu <weixugc@...gle.com>, Yosry Ahmed <yosry.ahmed@...ux.dev>,
 Yuanchu Xie <yuanchu@...gle.com>
Subject: Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values

…
> +++ b/mm/zswap.c
> @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>  
>  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
>  	if (IS_ERR(acomp)) {
…
> +		pr_err("could not alloc crypto acomp %s : %pe\n",
> +				pool->tfm_name, acomp);
>  		ret = PTR_ERR(acomp);
…

Would you like to reduce the indentation for the passed parameters?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110

Regards,
Markus