linux-kernel - Re: [PATCH 2/3] mm/vmscan: use %pe to print PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76cfa66f-2254-465d-8977-28915ed5cbc1@web.de>
Date: Tue, 18 Nov 2025 14:15:38 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Sahil Chandna <chandna.sahil@...il.com>, linux-mm@...ck.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Axel Rasmussen <axelrasmussen@...gle.com>,
 Chengming Zhou <chengming.zhou@...ux.dev>,
 David Hildenbrand <david@...hat.com>, Johannes Weiner <hannes@...xchg.org>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Michal Hocko
 <mhocko@...e.com>, Mike Rapoport <rppt@...nel.org>,
 Nhat Pham <nphamcs@...il.com>, Qi Zheng <zhengqi.arch@...edance.com>,
 Shakeel Butt <shakeel.butt@...ux.dev>, Suren Baghdasaryan
 <surenb@...gle.com>, Vlastimil Babka <vbabka@...e.cz>,
 Wei Xu <weixugc@...gle.com>, Yosry Ahmed <yosry.ahmed@...ux.dev>,
 Yuanchu Xie <yuanchu@...gle.com>
Subject: Re: [PATCH 2/3] mm/vmscan: use %pe to print PTR_ERR() values

…
> +++ b/mm/vmscan.c
> @@ -7500,8 +7500,8 @@ void __meminit kswapd_run(int nid)
>  		pgdat->kswapd = kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d", nid);
>  		if (IS_ERR(pgdat->kswapd)) {
…
> +			pr_err("Failed to start kswapd on node %d,ret=%pe\n",
> +				   nid, pgdat->kswapd);
>  			BUG_ON(system_state < SYSTEM_RUNNING);
…

I propose to adjust the indentation for the passed parameters.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110

Regards,
Markus