linux-kernel - Re: [PATCH 1/3] mm/pagewalk: use min() macro instead of manual ternary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118104537.7ebf4422@pumpkin>
Date: Tue, 18 Nov 2025 10:45:37 +0000
From: David Laight <david.laight.linux@...il.com>
To: Sahil Chandna <chandna.sahil@...il.com>
Cc: akpm@...ux-foundation.org, david@...hat.com, lorenzo.stoakes@...cle.com,
 mhocko@...e.com, vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com,
 hannes@...xchg.org, shakeel.butt@...ux.dev, zhengqi.arch@...edance.com,
 Liam.Howlett@...cle.com, weixugc@...gle.com, axelrasmussen@...gle.com,
 yuanchu@...gle.com, yosry.ahmed@...ux.dev, nphamcs@...il.com,
 chengming.zhou@...ux.dev, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mm/pagewalk: use min() macro instead of manual
 ternary

On Tue, 18 Nov 2025 11:38:49 +0530
Sahil Chandna <chandna.sahil@...il.com> wrote:

>  mm: pagewalk: use min() macro instead of manual ternary expression
> 
> Use the kernel-provided min() macro to compute the minimum value instead
> of an explicit ternary expression. This improves readability and matches
> common kernel style.
> 
> This was flagged by Coccinelle
> (misc/minmax.cocci) as an opportunity to use min().
> 
> Found by: make coccicheck MODE=report M=mm/
> No functional change intended.
> 
> Signed-off-by: Sahil Chandna <chandna.sahil@...il.com>
> ---
>  mm/pagewalk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
> index 9f91cf85a5be..82db421b5b34 100644
> --- a/mm/pagewalk.c
> +++ b/mm/pagewalk.c
> @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
>  				       unsigned long end)
>  {
>  	unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
> -	return boundary < end ? boundary : end;
> +	return min(boundary, end);

You can remove the temporary:
	return min((addr & huge_page_mask(h)) + huge_page_size(h), end);

  David

>  }
>  
>  static int walk_hugetlb_range(unsigned long addr, unsigned long end,