linux-kernel - Re: [PATCH] r8169: add support for RTL8127ATF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRzsxg_MEnGgu2lB@google.com>
Date: Tue, 18 Nov 2025 22:01:42 +0000
From: Fabio Baltieri <fabio.baltieri@...il.com>
To: Michael Zimmermann <sigmaepsilon92@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>,
	nic_swsd@...ltek.com, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8169: add support for RTL8127ATF

On Tue, Nov 18, 2025 at 10:31:54PM +0100, Michael Zimmermann wrote:
> One thing the out-of-tree driver does, which your patch doesn't do, is
> disabling eee when in fiber mode. I'd suggest something like this:
> @@ -845,7 +860,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp)
>  {
>         return tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
>                tp->mac_version != RTL_GIGA_MAC_VER_37 &&
> -              tp->mac_version != RTL_GIGA_MAC_VER_39;
> +              tp->mac_version != RTL_GIGA_MAC_VER_39 &&
> +              !tp->fiber_enabled;
>  }

Heya, don't I have exactly that diff in the patch? The second chunk

@@ -842,7 +843,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp)
 {
 	return tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
 	       tp->mac_version != RTL_GIGA_MAC_VER_37 &&
-	       tp->mac_version != RTL_GIGA_MAC_VER_39;
+	       tp->mac_version != RTL_GIGA_MAC_VER_39 &&
+	       !tp->fiber_mode;
 }