linux-kernel - Re: [PATCH] r8169: add support for RTL8127ATF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN9vWDKEDFmDiTuPB6ZQF02NYy0QiW2Oo7v4Zcu6tSiMH5Kj9Q@mail.gmail.com>
Date: Wed, 19 Nov 2025 08:00:01 +0100
From: Michael Zimmermann <sigmaepsilon92@...il.com>
To: Fabio Baltieri <fabio.baltieri@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>, nic_swsd@...ltek.com, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8169: add support for RTL8127ATF

On Tue, Nov 18, 2025 at 11:01 PM Fabio Baltieri
<fabio.baltieri@...il.com> wrote:
>
> On Tue, Nov 18, 2025 at 10:31:54PM +0100, Michael Zimmermann wrote:
> > One thing the out-of-tree driver does, which your patch doesn't do, is
> > disabling eee when in fiber mode. I'd suggest something like this:
> > @@ -845,7 +860,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp)
> >  {
> >         return tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
> >                tp->mac_version != RTL_GIGA_MAC_VER_37 &&
> > -              tp->mac_version != RTL_GIGA_MAC_VER_39;
> > +              tp->mac_version != RTL_GIGA_MAC_VER_39 &&
> > +              !tp->fiber_enabled;
> >  }
>
> Heya, don't I have exactly that diff in the patch? The second chunk
>
> @@ -842,7 +843,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp)
>  {
>         return tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
>                tp->mac_version != RTL_GIGA_MAC_VER_37 &&
> -              tp->mac_version != RTL_GIGA_MAC_VER_39;
> +              tp->mac_version != RTL_GIGA_MAC_VER_39 &&
> +              !tp->fiber_mode;
>  }

You're right, no idea how I missed that, sorry.

I've also done some testing with the out-of-tree driver:
- (my normal setup) a DAC between the rt8127 and a 10G switch works just fine.
- RJ45 10G modules on both sides works fine, but HwFiberModeVer stays
at 1 even after reloading the driver.
- RJ45 1G modules on both sides works after "ethtool -s enp1s0 speed
1000 duplex full autoneg on", but you have to do that while connected
via 10G because that driver is buggy and returns EINVAL otherwise.
HwFiberModeVer was 1 as well after reloading the driver.

What this means is that the fiber mode is always enabled on these
cards, which makes sense given that the out-of-tree driver only reads
it once when loading the driver. I guess it's either a hardware
variant, configured in the factory or detected using a pin of the
chip.
It also means that it doesn't matter to the linux driver what's
actually connected beyond the speed you want to use since - as others
have said before - this seems to be fully handled on the NIC.

Michael