linux-kernel - Re: [bpf-next v1 1/5] selftests/bpf: use sockaddr_storage instead of addr_port in cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9ed9de08-9a5b-4fc9-9213-ca918dafea0b@linux.dev>
Date: Tue, 18 Nov 2025 15:12:13 -0800
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Hoyeon Lee <hoyeon.lee@...e.com>
Cc: Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman
 <eddyz87@...il.com>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Shuah Khan <shuah@...nel.org>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [bpf-next v1 1/5] selftests/bpf: use sockaddr_storage instead of
 addr_port in cls_redirect test

On 11/15/25 2:55 PM, Hoyeon Lee wrote:

>   struct tuple {
>   	int family;

The "family" is not needed either. Just use the ss_family from src or 
dst. The 'struct tuple' can be removed also?

I'm on the fence about whether this "struct sockaddr_storage" change is 
worth the code churn. Are patch 1 and 2 the only tests that need this
change?

Patch 3 and 4 make sense. Patch 3 and 4 are applied.

Please post patch 5 as a separate patch on its own.

> -	struct addr_port src;
> -	struct addr_port dst;
> +	struct sockaddr_storage src;
> +	struct sockaddr_storage dst;
>   };