linux-kernel - Re: [bpf-next v1 1/5] selftests/bpf: use sockaddr_storage instead of addr_port in cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7-dKbxgFqw8cjfw3oWvZCQat=UKUq7u4zU+nx4xw-g5m4n_Q@mail.gmail.com>
Date: Wed, 19 Nov 2025 12:09:38 +0900
From: Hoyeon Lee <hoyeon.lee@...e.com>
To: Martin KaFai Lau <martin.lau@...ux.dev>
Cc: Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [bpf-next v1 1/5] selftests/bpf: use sockaddr_storage instead of
 addr_port in cls_redirect test

On Wed, Nov 19, 2025 at 8:12 AM Martin KaFai Lau <martin.lau@...ux.dev> wrote:
>
> On 11/15/25 2:55 PM, Hoyeon Lee wrote:
>
> >   struct tuple {
> >       int family;
>
> The "family" is not needed either. Just use the ss_family from src or
> dst. The 'struct tuple' can be removed also?
>
> I'm on the fence about whether this "struct sockaddr_storage" change is
> worth the code churn. Are patch 1 and 2 the only tests that need this
> change?
>

Thanks for the feedback.

Yes, patches 1 and 2 are the only tests that use a custom address/port
representation. These are the last remaining cases, and no further
changes are needed elsewhere. The code churn is fully contained within
these two patches.

For the “family” field, agreed. ss_family is sufficient, and the tuple
wrapper can be removed. If you're okay with that direction, I can drop
the family field and resend patches 1 and 2 with that cleanup applied.

> Patch 3 and 4 make sense. Patch 3 and 4 are applied.
>
> Please post patch 5 as a separate patch on its own.
>

Thanks for applying patches 3 and 4. I will send patch 5 separately as
requested.

Thanks again for your time.


> > -     struct addr_port src;
> > -     struct addr_port dst;
> > +     struct sockaddr_storage src;
> > +     struct sockaddr_storage dst;
> >   };
>